Allow transitioning to HAVE_METADATA before pipeline initialization completes.

media/base/pipeline.h

Index: media/base/pipeline.h
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index ecad11c7ddd07831d9f859a8944bf64e5472715d..70624c4746a70857115ee4e6f96dd6cc0d0691cb 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -97,24 +97,35 @@ class MEDIA_EXPORT Pipeline
     : public base::RefCountedThreadSafe<Pipeline>,
       public DemuxerHost {
  public:
+  // Current buffering state in terms of HTMLMediaElement.readyState values.

[scherkus (not reviewing), 2012/08/15 23:46:55]

layering violation in comment form!

instead of a catch-all comment we should define these states in terms of
pipeline operations (i.e., kHaveMetadata -> natural size / duration / etc... are
queryable)

[acolwell GONE FROM CHROMIUM, 2012/08/16 00:54:18]

Done.

+  enum ReadyState {
+    kHaveMetadata,
+    kHaveEnoughData,
+  };
+
+  typedef base::Callback<void(ReadyState)> ReadyStateCB;
+
   // Constructs a media pipeline that will execute on |message_loop|.
   Pipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop,
            MediaLog* media_log);
 
   // Build a pipeline to using the given filter collection to construct a filter
-  // chain, executing |start_cb| when initialization has completed.
+  // chain, executing |seek_cb| when the initial seek/preroll has completed.
   //
   // The following permanent callbacks will be executed as follows up until
   // Stop() has completed:
   //   |ended_cb| will be executed whenever the media reaches the end.
   //   |error_cb| will be executed whenever an error occurs but hasn't
   //              been reported already through another callback.
-  //
+  //   |ready_state_cb| will be executed whenever the pipeline does something
+  //                    that should trigger a HTMLMediaElement.readyState

[scherkus (not reviewing), 2012/08/15 23:46:55]

ditto -- this comment shouldn't reference what the client should do (it's up to
the client!)

what about mentioning that this cb is optional?

[acolwell GONE FROM CHROMIUM, 2012/08/16 00:54:18]

Done.

+  //                    transition.
   // It is an error to call this method after the pipeline has already started.
   void Start(scoped_ptr<FilterCollection> filter_collection,
              const PipelineStatusCB& ended_cb,
              const PipelineStatusCB& error_cb,
-             const PipelineStatusCB& start_cb);
+             const PipelineStatusCB& seek_cb,
+             const ReadyStateCB& ready_state_cb);
 
   // Asynchronously stops the pipeline, executing |stop_cb| when the pipeline
   // teardown has completed.
@@ -233,11 +244,9 @@ class MEDIA_EXPORT Pipeline
   // Helper method to tell whether we are in transition to seek state.
   bool IsPipelineSeeking();
 
-  // Helper method to execute callback from Start() and reset
-  // |filter_collection_|. Called when initialization completes
-  // normally or when pipeline is stopped or error occurs during
-  // initialization.
-  void FinishInitialization();
+  // Helper method that runs & resets |seek_cb_| and resets |seek_timestamp_|
+  // and |seek_pending_|.
+  void FinishSeek();
 
   // Returns true if the given state is one that transitions to a new state
   // after iterating through each filter.
@@ -296,7 +305,8 @@ class MEDIA_EXPORT Pipeline
   void StartTask(scoped_ptr<FilterCollection> filter_collection,
                  const PipelineStatusCB& ended_cb,
                  const PipelineStatusCB& error_cb,
-                 const PipelineStatusCB& start_cb);
+                 const PipelineStatusCB& seek_cb,
+                 const ReadyStateCB& ready_state_cb);
 
   // InitializeTask() performs initialization in multiple passes. It is executed
   // as a result of calling Start() or InitializationComplete() that advances
@@ -494,6 +504,7 @@ class MEDIA_EXPORT Pipeline
   base::Closure stop_cb_;
   PipelineStatusCB ended_cb_;
   PipelineStatusCB error_cb_;
+  ReadyStateCB ready_state_cb_;
 
   // Audio renderer reference used for setting the volume and determining
   // when playback has finished.