Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 10854060: ash: Use different hit-test outer-region for mouse and touch events. (Closed)

Created:
8 years, 4 months ago by sadrul
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, ben+watch_chromium.org, tfarina, jeremya+watch_chromium.org, Aaron Boodman
Visibility:
Public.

Description

ash: Use different hit-test outer-region for mouse and touch events. The hit-region for windows need to be larger for touch events to allow resizing windows easily, while continuing to use a smaller hit-region for mouse-events. BUG=135187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150870

Patch Set 1 #

Patch Set 2 : update-test #

Patch Set 3 : scale #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -32 lines) Patch
M ash/ash_constants.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_constants.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/frame_painter.cc View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 2 3 chunks +12 lines, -9 lines 0 comments Download
M ui/aura/window.h View 1 2 2 chunks +11 lines, -7 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/aura/window_unittest.cc View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M ui/oak/oak_aura_window_display.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sadrul
8 years, 4 months ago (2012-08-09 04:47:51 UTC) #1
sky
Is it possible to scale the mouse values in some way so folks don't have ...
8 years, 4 months ago (2012-08-09 16:02:59 UTC) #2
sadrul
On 2012/08/09 16:02:59, sky wrote: > Is it possible to scale the mouse values in ...
8 years, 4 months ago (2012-08-09 16:15:41 UTC) #3
sadrul
On 2012/08/09 16:15:41, sadrul wrote: > On 2012/08/09 16:02:59, sky wrote: > > Is it ...
8 years, 4 months ago (2012-08-09 16:28:29 UTC) #4
sky
SGTM
8 years, 4 months ago (2012-08-09 16:39:01 UTC) #5
sadrul
On 2012/08/09 16:39:01, sky wrote: > SGTM Done.
8 years, 4 months ago (2012-08-09 17:08:00 UTC) #6
sky
8 years, 4 months ago (2012-08-09 19:37:05 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698