Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2443)

Unified Diff: base/allocator/allocator.gyp

Issue 10854031: Support vtable_verify (new compiler option). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed common.gypi changes; further discussion led to conclusion it's not needed. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/allocator.gyp
diff --git a/base/allocator/allocator.gyp b/base/allocator/allocator.gyp
index e2c8ac0faeb383fd96b138b1f99b23c830ab21bb..8f14f3776cbbc0d7c397086ab9e384fd1c3cacca 100644
--- a/base/allocator/allocator.gyp
+++ b/base/allocator/allocator.gyp
@@ -394,6 +394,16 @@
'-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14UnIgnoreObjectEPKv',
]},
}],
+ [ 'use_vtable_verify==1', {
Mark Mentovai 2012/08/14 21:31:54 Since you’ve removed use_vtable_verify from common
Mark Mentovai 2012/08/15 00:18:41 You do need to provide a default definition of use
+ 'cflags': [
+ '-Wno-sign-compare',
+ '-Wno-unused-result',
+ '-fvtable-verify=preinit',
+ ],
+ 'cflags!': [
+ '-fvtable-verify=std',
Mark Mentovai 2012/08/14 21:32:23 If nothing is adding this option any more, you can
Mark Mentovai 2012/08/15 00:18:41 How would cflags ever contain -fvtable-verify=std?
+ ],
+ }],
[ 'linux_use_debugallocation==1', {
'sources!': [
# debugallocation.cc #includes tcmalloc.cc,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698