Support vtable_verify (new compiler option).

base/allocator/allocator.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {

[Mark Mentovai, 2012/08/15 00:18:41]

This is a good variables section to use for your default definition (see below).

     'jemalloc_dir': '../../third_party/jemalloc/chromium',
     'tcmalloc_dir': '../../third_party/tcmalloc/chromium',
   },
   'targets': [
     {
       'target_name': 'allocator',
       'type': 'static_library',
       # Make sure the allocation library is optimized to
       # the hilt in official builds.
       'variables': {
@@ skipping 370 matching lines @@
             'ldflags': [
               # Don't let linker rip this symbol out, otherwise the heap&cpu
               # profilers will not initialize properly on startup.
               '-Wl,-uIsHeapProfilerRunning,-uProfilerStart',
               # Do the same for heap leak checker.
               '-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_MMapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi',
               '-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_MMapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl',
               '-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakChecker14UnIgnoreObjectEPKv',
           ]},
         }],
+        [ 'use_vtable_verify==1', {

[Mark Mentovai, 2012/08/14 21:31:54]

Since you’ve removed use_vtable_verify from common.gypi AND you haven’t provided
a default definition anywhere here, this will now cause gyp to throw an
exception

(except in the rare and unexpected case where a user has affirmatively set this
GYP variable manually in GYP_DEFINES, ~/.gyp/include.gypi, or -D.)

[Mark Mentovai, 2012/08/15 00:18:41]

You do need to provide a default definition of use_vtable_verify just as you had
done before in common.gypi. It can be in this file. It should look something
like

  'variables': {
    'use_vtable_verify%': 0,
  },

A run through the Chromium try servers should tell you whether you’ve gotten
this right, since as I mentioned, nothing elsewhere will be setting this GYP
variable.

+          'cflags': [
+            '-Wno-sign-compare',
+            '-Wno-unused-result',
+            '-fvtable-verify=preinit',
+          ],
+          'cflags!': [
+            '-fvtable-verify=std',

[Mark Mentovai, 2012/08/14 21:32:23]

If nothing is adding this option any more, you can remove the cflags! that
excludes it.

[Mark Mentovai, 2012/08/15 00:18:41]

How would cflags ever contain -fvtable-verify=std? Nothing anywhere in the GYP
files ever specifies it.

+          ],
+        }],
         [ 'linux_use_debugallocation==1', {
           'sources!': [
             # debugallocation.cc #includes tcmalloc.cc,
             # so only one of them should be used.
             '<(tcmalloc_dir)/src/tcmalloc.cc',
           ],
           'defines': [
             'TCMALLOC_FOR_DEBUGALLOCATION',
           ],
         }, { # linux_use_debugallocation != 1
@@ skipping 118 matching lines @@
         'dependencies': [
           '../../testing/gtest.gyp:gtest',
           '../base.gyp:base',
           'allocator',
         ],
       },
       ],
     }],
   ],
 }