Issue 10854: Restructor the the pump for nested loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854: Restructor the the pump for nested loops. (Closed)

Created:
12 years, 1 month ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), dsh, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Restructure the the pump for nested loops. Change our work dispatching to be based around an event source. This will allow us to still participate when a message loop is pumped by outside code (nested message loops).

Patch Set 1 #

Patch Set 2 : Remove a stale comment. #

Patch Set 3 : Remove a stale comment. #

Patch Set 4 : Run at an idle level. #

Patch Set 5 : Fix attempt at priority starvation. #

Patch Set 6 : Remove accidental old code #

Patch Set 7 : x #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -42 lines)			Patch
	M	base/message_pump_glib.h	View		2 chunks	+12 lines, -0 lines	0 comments	Download
	M	base/message_pump_glib.cc	View	1 3 4 5	3 chunks	+71 lines, -42 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dsh

http://codereview.chromium.org/10854/diff/1/2 File base/message_pump_glib.cc (right): http://codereview.chromium.org/10854/diff/1/2#newcode176 Line 176: if (state_->delegate->DoIdleWork()) In the Windows pump, we only ...

12 years, 1 month ago (2008-11-12 22:40:56 UTC) #2

dsh

It looks good if the comment is correct and we don't mind giving priority to ...

12 years, 1 month ago (2008-11-12 23:06:19 UTC) #3

dsh

12 years, 1 month ago (2008-11-12 23:48:39 UTC) #4

LGTM

http://codereview.chromium.org/10854/diff/10/219
File base/message_pump_glib.cc (right):

http://codereview.chromium.org/10854/diff/10/219#newcode154
Line 154: // here without having been through Dispatch(), will get a chance to
be
Should this have a "we" before "will"?

Expand Messages | Collapse Messages