Initial constants for new ConstrainedWindow style.

chrome/browser/ui/constrained_window.h

Index: chrome/browser/ui/constrained_window.h
diff --git a/chrome/browser/ui/constrained_window.h b/chrome/browser/ui/constrained_window.h
index 720ccb897a812652b0bf83fd206bcae7cddac4aa..0b339239d262a4fa9c97b1eac6db34fa78f7bfc7 100644
--- a/chrome/browser/ui/constrained_window.h
+++ b/chrome/browser/ui/constrained_window.h
@@ -6,6 +6,7 @@
 #define CHROME_BROWSER_UI_CONSTRAINED_WINDOW_H_
 
 #include "build/build_config.h"
+#include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/native_widget_types.h"
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -16,6 +17,7 @@
 //
 class ConstrainedWindow {
  public:
+   const int kFoo = 23;
   // Makes the Constrained Window visible. Only one Constrained Window is shown
   // at a time per tab.
   virtual void ShowConstrainedWindow() = 0;
@@ -33,4 +35,27 @@ class ConstrainedWindow {
   virtual ~ConstrainedWindow() {}
 };
 
+namespace ConstrainedWindowStyle {

[Ben Goodger (Google), 2012/08/03 23:09:07]

we don't use namespaces like this. according to google style, they must be based
on directories/files.

[groby-ooo-7-16, 2012/08/03 23:18:20]

So make the constants part of the class, then? (They're specific to
ConstrainedWindow, not browser::ui)
On 2012/08/03 23:09:07, Ben Goodger (Google) wrote:

[groby-ooo-7-16, 2012/08/13 22:17:30]

Done.

+
+const int kVerticalPadding = 14; // top/bottom padding.

[Ben Goodger (Google), 2012/08/03 23:09:07]

I am also surprised to find all these constants in this cross platform file. I
expect that they will vary slightly for each platform/port, even though the
result will look very similar.

[groby-ooo-7-16, 2012/08/03 23:18:20]

According to the mocks, these are the same across platforms. See
http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Dialogs/Markup2...

I assume I'll break them up once they start differing.

[groby-ooo-7-16, 2012/08/13 22:17:30]

Done.

+const int kHorizontalPadding = 17; // left/right padding.
+const int kRowPadding = 20;  // Vertical margin between dialog rows.
+const int kBorderRadius = 2;  // Border radius for dialog corners.
+
+// Font sizes (in px) for title and dialog text.
+#if defined(OS_CHROMEOS) || defined(OS_WIN)
+const int kTitleFontSize = 16;
+const int kTextFontSize = 13;
+#else
+const int kTitleFontSize = 15;
+const int kTextFontSize = 13;
+#endif
+
+extern const SkColor kBackgroundColor;  // Dialog background color.
+extern const SkColor kTextColor;  // Dialog text color.
+
+extern const char kFont[];
+
+}
+
 #endif  // CHROME_BROWSER_UI_CONSTRAINED_WINDOW_H_