Initial constants for new ConstrainedWindow style.

chrome/browser/ui/constrained_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_CONSTRAINED_WINDOW_H_
 #define CHROME_BROWSER_UI_CONSTRAINED_WINDOW_H_
 
 #include "build/build_config.h"
+#include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/native_widget_types.h"
 
 ///////////////////////////////////////////////////////////////////////////////
 // ConstrainedWindow
 //
 //  This interface represents a window that is constrained to a
 //  WebContentsView's bounds.
 //
 class ConstrainedWindow {
  public:
+   const int kFoo = 23;
   // Makes the Constrained Window visible. Only one Constrained Window is shown
   // at a time per tab.
   virtual void ShowConstrainedWindow() = 0;
 
   // Closes the Constrained Window.
   virtual void CloseConstrainedWindow() = 0;
 
   // Sets focus on the Constrained Window.
   virtual void FocusConstrainedWindow();
 
   // Returns the native window of the constrained window.
   virtual gfx::NativeWindow GetNativeWindow();
 
  protected:
   virtual ~ConstrainedWindow() {}
 };
 
+namespace ConstrainedWindowStyle {

[Ben Goodger (Google), 2012/08/03 23:09:07]

we don't use namespaces like this. according to google style, they must be based
on directories/files.

[groby-ooo-7-16, 2012/08/03 23:18:20]

So make the constants part of the class, then? (They're specific to
ConstrainedWindow, not browser::ui)
On 2012/08/03 23:09:07, Ben Goodger (Google) wrote:

[groby-ooo-7-16, 2012/08/13 22:17:30]

Done.

+
+const int kVerticalPadding = 14; // top/bottom padding.

[Ben Goodger (Google), 2012/08/03 23:09:07]

I am also surprised to find all these constants in this cross platform file. I
expect that they will vary slightly for each platform/port, even though the
result will look very similar.

[groby-ooo-7-16, 2012/08/03 23:18:20]

According to the mocks, these are the same across platforms. See
http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Dialogs/Markup2...

I assume I'll break them up once they start differing.

[groby-ooo-7-16, 2012/08/13 22:17:30]

Done.

+const int kHorizontalPadding = 17; // left/right padding.
+const int kRowPadding = 20;  // Vertical margin between dialog rows.
+const int kBorderRadius = 2;  // Border radius for dialog corners.
+
+// Font sizes (in px) for title and dialog text.
+#if defined(OS_CHROMEOS) || defined(OS_WIN)
+const int kTitleFontSize = 16;
+const int kTextFontSize = 13;
+#else
+const int kTitleFontSize = 15;
+const int kTextFontSize = 13;
+#endif
+
+extern const SkColor kBackgroundColor;  // Dialog background color.
+extern const SkColor kTextColor;  // Dialog text color.
+
+extern const char kFont[];
+
+}
+
 #endif  // CHROME_BROWSER_UI_CONSTRAINED_WINDOW_H_