Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1444)

Unified Diff: tools/licenses.py

Issue 10843069: Remove superfluous pruned paths from license tool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/licenses.py
diff --git a/tools/licenses.py b/tools/licenses.py
index 2a87df7f731cc7f794859a1be92505ace87003cd..a6951336591d460b096264ded8b8860b01a9bc5f 100755
--- a/tools/licenses.py
+++ b/tools/licenses.py
@@ -27,10 +27,6 @@ PRUNE_PATHS = set([
# Assume for now that breakpad has their licensing in order.
os.path.join('breakpad'),
- # This is just a tiny vsprops file, presumably written by the google-url
- # authors. Not third-party code.
- os.path.join('googleurl','third_party','icu'),
Nico 2012/08/04 21:40:15 Sounds like a bug that this doesn't cause license
Steve Block 2012/08/06 11:14:28 We don't need this as we now check src/googleurl a
-
# Assume for now that native client has their licensing in order.
os.path.join('native_client'),
@@ -41,10 +37,7 @@ PRUNE_PATHS = set([
os.path.join('third_party','nss'),
os.path.join('net','third_party','nss'),
- # We don't bundle o3d samples into our resulting binaries.
- os.path.join('o3d','samples'),
Nico 2012/08/04 21:40:15 This one's ok, we removed o3d a while ago.
-
- # Not in the public Chromium tree.
+ # Placeholder directory only, not third-party code.
os.path.join('third_party','adobe'),
# Written as part of Chromium.
@@ -53,15 +46,10 @@ PRUNE_PATHS = set([
# Same license as Chromium.
os.path.join('third_party','lss'),
- # Only binaries, used during development.
- os.path.join('third_party','valgrind'),
Nico 2012/08/04 21:40:15 This is checked out only on the valgrind bots, so
Steve Block 2012/08/06 11:14:28 Ah, I see. Where is that specified? I didn't see a
Nico 2012/08/06 23:54:24 http://www.chromium.org/developers/how-tos/using-v
-
- # Two directories that are the same as those in base/third_party.
- os.path.join('v8','src','third_party','dtoa'),
+ # Directories that are the same as those in base/third_party.
os.path.join('v8','src','third_party','valgrind'),
# Used for development and test, not in the shipping product.
- os.path.join('third_party','android_testrunner'),
Nico 2012/08/04 21:40:15 This is probably checked out on the android bots,
Steve Block 2012/08/06 11:14:28 Yes, it is, but the metadata is all good.
os.path.join('third_party','bidichecker'),
os.path.join('third_party','cygwin'),
os.path.join('third_party','gold'),
@@ -78,11 +66,6 @@ PRUNE_PATHS = set([
os.path.join('third_party', 'psutils'),
os.path.join('third_party', 'sawbuck'),
- # Redistribution does not require attribution in documentation.
- os.path.join('third_party','directxsdk'),
- os.path.join('third_party','platformsdk_win2008_6_1'),
- os.path.join('third_party','platformsdk_win7'),
Nico 2012/08/04 21:40:15 This is checked out for people who map src-interna
Steve Block 2012/08/06 11:14:28 OK
-
# Harfbuzz-ng is not currently shipping in any product:
os.path.join('third_party','harfbuzz-ng'),
])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698