Remove superfluous pruned paths from license tool

tools/licenses.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility for checking and processing licensing information in third_party
 directories.
 
 Usage: licenses.py <command>
 
 Commands:
   scan     scan third_party directories, verifying that we have licensing info
   credits  generate about:credits on stdout
 
 (You can also import this as a module.)
 """
 
 import cgi
 import os
 import sys
 
 # Paths from the root of the tree to directories to skip.
 PRUNE_PATHS = set([
     # Same module occurs in both the top-level third_party and others.
     os.path.join('base','third_party','icu'),
 
     # Assume for now that breakpad has their licensing in order.
     os.path.join('breakpad'),
 
-    # This is just a tiny vsprops file, presumably written by the google-url
-    # authors.  Not third-party code.
-    os.path.join('googleurl','third_party','icu'),

[Nico, 2012/08/04 21:40:15]

Sounds like a bug that this doesn't cause license errors, as it's in a
third_party folder without a LICENSE / README.chromium?

[Steve Block, 2012/08/06 11:14:28]

We don't need this as we now check src/googleurl as an additional path, and the
tool doesn't check child directories.

-
     # Assume for now that native client has their licensing in order.
     os.path.join('native_client'),
 
     # Same module occurs in chrome/ and in net/, so skip one of them.
     os.path.join('net','third_party','mozilla_security_manager'),
 
     # Same module occurs in base/, net/, and src/ so skip all but one of them.
     os.path.join('third_party','nss'),
     os.path.join('net','third_party','nss'),
 
-    # We don't bundle o3d samples into our resulting binaries.
-    os.path.join('o3d','samples'),

[Nico, 2012/08/04 21:40:15]

This one's ok, we removed o3d a while ago.

-
-    # Not in the public Chromium tree.
+    # Placeholder directory only, not third-party code.
     os.path.join('third_party','adobe'),
 
     # Written as part of Chromium.
     os.path.join('third_party','fuzzymatch'),
 
     # Same license as Chromium.
     os.path.join('third_party','lss'),
 
-    # Only binaries, used during development.
-    os.path.join('third_party','valgrind'),

[Nico, 2012/08/04 21:40:15]

This is checked out only on the valgrind bots, so we probably want to keep this?

[Steve Block, 2012/08/06 11:14:28]

Ah, I see. Where is that specified? I didn't see anything in DEPS.

[Nico, 2012/08/06 23:54:24]

http://www.chromium.org/developers/how-tos/using-valgrind

I think the valgrind bots have special deps somewhere else?

-
-    # Two directories that are the same as those in base/third_party.
-    os.path.join('v8','src','third_party','dtoa'),
+    # Directories that are the same as those in base/third_party.
     os.path.join('v8','src','third_party','valgrind'),
 
     # Used for development and test, not in the shipping product.
-    os.path.join('third_party','android_testrunner'),

[Nico, 2012/08/04 21:40:15]

This is probably checked out on the android bots, but not sure.

[Steve Block, 2012/08/06 11:14:28]

Yes, it is, but the metadata is all good.

     os.path.join('third_party','bidichecker'),
     os.path.join('third_party','cygwin'),
     os.path.join('third_party','gold'),
     os.path.join('third_party','lighttpd'),
     os.path.join('third_party','mingw-w64'),
     os.path.join('third_party','pefile'),
     os.path.join('third_party','python_26'),
 
     # Stuff pulled in from chrome-internal for official builds/tools.
     os.path.join('third_party', 'clear_cache'),
     os.path.join('third_party', 'gnu'),
     os.path.join('third_party', 'googlemac'),
     os.path.join('third_party', 'pcre'),
     os.path.join('third_party', 'psutils'),
     os.path.join('third_party', 'sawbuck'),
 
-    # Redistribution does not require attribution in documentation.
-    os.path.join('third_party','directxsdk'),
-    os.path.join('third_party','platformsdk_win2008_6_1'),
-    os.path.join('third_party','platformsdk_win7'),

[Nico, 2012/08/04 21:40:15]

This is checked out for people who map src-internal on windows (e.g. windows
bots)

[Steve Block, 2012/08/06 11:14:28]

OK

-
     # Harfbuzz-ng is not currently shipping in any product:
     os.path.join('third_party','harfbuzz-ng'),
 ])
 
 # Directories we don't scan through.
 PRUNE_DIRS = ('.svn', '.git',             # VCS metadata
               'out', 'Debug', 'Release',  # build files
               'layout_tests')             # lots of subdirs
 
 ADDITIONAL_PATHS = (
@@ skipping 295 matching lines @@
     elif command == 'credits':
         if not GenerateCredits():
             return 1
     else:
         print __doc__
         return 1
 
 
 if __name__ == '__main__':
   sys.exit(main())