Chromium Code Reviews| Index: chrome/browser/resources/options2/chromeos/display_options.html |
| diff --git a/chrome/browser/resources/options2/chromeos/display_options.html b/chrome/browser/resources/options2/chromeos/display_options.html |
| index a6dea53b99fdc40135379ef81ab65a12a1150956..7c35f21bc2e3323fefa6dacb11db800d95d1473b 100644 |
| --- a/chrome/browser/resources/options2/chromeos/display_options.html |
| +++ b/chrome/browser/resources/options2/chromeos/display_options.html |
| @@ -1,18 +1,33 @@ |
| <div id="display-options" class="page" hidden> |
| <div class="close-button"></div> |
| <h1 i18n-content="displayOptionsPage"></h1> |
| - <div class="content-area"> |
| + <div class="content-area" id="display-options-content-area"> |
| <div id="display-options-displays-view-host"> |
| </div> |
| <div id="display-configurations"> |
| - <button id="display-options-toggle-mirroring" |
| - i18n-content="startMirroring"> |
| - </button> |
| + <div id="selected-display-data-container"> |
| + <span id="selected-display-name"></span><br/> |
|
James Hawkins
2012/08/03 18:08:23
Don't use <br> when you really want a block elemen
Jun Mukai
2012/08/06 08:07:32
Done.
|
| + <span i18n-content="resolution"></span>: |
|
James Hawkins
2012/08/03 18:08:23
I'm not a fan of this colon here; I don't think it
Jun Mukai
2012/08/06 08:07:32
Done.
|
| + <span id="selected-display-resolution"></span> |
| + </div> |
| + <div id="display-options-buttons-container"> |
| + <div class="display-options-single-button-container"> |
| + <button id="display-options-toggle-mirroring" |
| + class="display-options-button" |
| + i18n-content="startMirroring"> |
|
James Hawkins
2012/08/03 18:08:23
Does this not fit on the line above? It's hard to
Jun Mukai
2012/08/06 08:07:32
Done.
|
| + </button> |
| + </div> |
| + <div class="display-options-single-button-container"> |
| + <button id="display-options-apply-button" |
|
James Hawkins
2012/08/03 18:08:23
Don't use the element name in the ID, e.g., button
Jun Mukai
2012/08/06 08:07:32
Done.
|
| + class="display-options-button" |
| + i18n-content="applyButton"> |
| + </button> |
| + </div> |
| + </div> |
| </div> |
| - </div> |
| - <div class="action-area"> |
| - <div class="button-strip"> |
| - <button id="display-options-confirm" i18n-content="ok"></button> |
| + <!-- the arrow of display-configuration is achieved by a div |
|
James Hawkins
2012/08/03 18:08:23
nit: Capitalize first word of sentence.
Jun Mukai
2012/08/06 08:07:32
Done.
|
| + rotated by 45deg. --> |
| + <div id="display-configuration-arrow"> |
| </div> |
| </div> |
| </div> |