chrome/browser/resources/options2/chromeos/display_options.html - Issue 10843066: Polish "Displays" Options UI for ChromeOS.

Side by Side Diff: chrome/browser/resources/options2/chromeos/display_options.html

Issue 10843066: Polish "Displays" Options UI for ChromeOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: blue -> skyblue Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/options2/chromeos/display_options.css ('K') | « chrome/browser/resources/options2/chromeos/display_options.css ('k') | chrome/browser/resources/options2/chromeos/display_options.js » ('j') | chrome/browser/resources/options2/chromeos/display_options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="display-options" class="page" hidden>	1 <div id="display-options" class="page" hidden>

2 <div class="close-button"></div>	2 <div class="close-button"></div>

3 <h1 i18n-content="displayOptionsPage"></h1>	3 <h1 i18n-content="displayOptionsPage"></h1>

4 <div class="content-area">	4 <div class="content-area" id="display-options-content-area">

5 <div id="display-options-displays-view-host">	5 <div id="display-options-displays-view-host">

6 </div>	6 </div>

7 <div id="display-configurations">	7 <div id="display-configurations">

8 <button id="display-options-toggle-mirroring"	8 <div id="selected-display-data-container">

9 i18n-content="startMirroring">	9 <span id="selected-display-name"></span><br/>
	James Hawkins 2012/08/03 18:08:23 Don't use <br> when you really want a block elemen Don't use <br> when you really want a block element. Jun Mukai 2012/08/06 08:07:32 Done. Show quoted text On 2012/08/03 18:08:23, James Hawkins wrote: > Don't use <br> when you really want a block element. Done.
10 </button>	10 <span i18n-content="resolution"></span>:
	James Hawkins 2012/08/03 18:08:23 I'm not a fan of this colon here; I don't think it I'm not a fan of this colon here; I don't think it will work like you want it to in RTL. Jun Mukai 2012/08/06 08:07:32 Done. Show quoted text On 2012/08/03 18:08:23, James Hawkins wrote: > I'm not a fan of this colon here; I don't think it will work like you want it to > in RTL. Done.
	11 <span id="selected-display-resolution"></span>

	12 </div>

	13 <div id="display-options-buttons-container">

	14 <div class="display-options-single-button-container">

	15 <button id="display-options-toggle-mirroring"

	16 class="display-options-button"

	17 i18n-content="startMirroring">
	James Hawkins 2012/08/03 18:08:23 Does this not fit on the line above? It's hard to Does this not fit on the line above? It's hard to eyeball it. Jun Mukai 2012/08/06 08:07:32 Done. Show quoted text On 2012/08/03 18:08:23, James Hawkins wrote: > Does this not fit on the line above? It's hard to eyeball it. Done.
	18 </button>

	19 </div>

	20 <div class="display-options-single-button-container">

	21 <button id="display-options-apply-button"
	James Hawkins 2012/08/03 18:08:23 Don't use the element name in the ID, e.g., button Don't use the element name in the ID, e.g., button. Jun Mukai 2012/08/06 08:07:32 Done. Show quoted text On 2012/08/03 18:08:23, James Hawkins wrote: > Don't use the element name in the ID, e.g., button. Done.
	22 class="display-options-button"

	23 i18n-content="applyButton">

	24 </button>

	25 </div>

	26 </div>

11 </div>	27 </div>

12 </div>	28 <!-- the arrow of display-configuration is achieved by a div
	James Hawkins 2012/08/03 18:08:23 nit: Capitalize first word of sentence. nit: Capitalize first word of sentence. Jun Mukai 2012/08/06 08:07:32 Done. Show quoted text On 2012/08/03 18:08:23, James Hawkins wrote: > nit: Capitalize first word of sentence. Done.
13 <div class="action-area">	29 rotated by 45deg. -->

14 <div class="button-strip">	30 <div id="display-configuration-arrow">

15 <button id="display-options-confirm" i18n-content="ok"></button>

16 </div>	31 </div>

17 </div>	32 </div>

18 </div>	33 </div>

OLD	NEW