Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/common/extensions/extension_icon_set_unittest.cc

Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_icon_set_unittest.cc
diff --git a/chrome/common/extensions/extension_icon_set_unittest.cc b/chrome/common/extensions/extension_icon_set_unittest.cc
index 433e0c86bf6e9b408dbaa13ec15ba19972fc5888..bfb26edd7ec20d850fecec0987b3eddd7a964af4 100644
--- a/chrome/common/extensions/extension_icon_set_unittest.cc
+++ b/chrome/common/extensions/extension_icon_set_unittest.cc
@@ -6,8 +6,10 @@
#include "testing/gtest/include/gtest/gtest.h"
+namespace {
+
TEST(ExtensionIconSet, Basic) {
- ExtensionIconSet icons;
+ ExtensionIconSet icons(ExtensionIconSet::ICON_SET_MANIFEST_ICONS);
EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE,
ExtensionIconSet::MATCH_EXACTLY));
EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE,
@@ -50,7 +52,7 @@ TEST(ExtensionIconSet, Basic) {
}
TEST(ExtensionIconSet, Values) {
- ExtensionIconSet icons;
+ ExtensionIconSet icons(ExtensionIconSet::ICON_SET_MANIFEST_ICONS);
EXPECT_FALSE(icons.ContainsPath("foo"));
icons.Add(ExtensionIconSet::EXTENSION_ICON_BITTY, "foo");
@@ -66,7 +68,7 @@ TEST(ExtensionIconSet, Values) {
}
TEST(ExtensionIconSet, FindSize) {
- ExtensionIconSet icons;
+ ExtensionIconSet icons(ExtensionIconSet::ICON_SET_MANIFEST_ICONS);
EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID,
icons.GetIconSizeFromPath("foo"));
@@ -86,3 +88,5 @@ TEST(ExtensionIconSet, FindSize) {
EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID,
icons.GetIconSizeFromPath("foo"));
}
+
+} // namespace

Powered by Google App Engine
This is Rietveld 408576698