Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: chrome/common/extensions/extension_icon_set_unittest.cc

Issue 10843014: Generalize ExtensionIconSet to store icon paths for custom size sets (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_icon_set.h" 5 #include "chrome/common/extensions/extension_icon_set.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace {
10
9 TEST(ExtensionIconSet, Basic) { 11 TEST(ExtensionIconSet, Basic) {
10 ExtensionIconSet icons; 12 ExtensionIconSet icons(ExtensionIconSet::ICON_SET_MANIFEST_ICONS);
11 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE, 13 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE,
12 ExtensionIconSet::MATCH_EXACTLY)); 14 ExtensionIconSet::MATCH_EXACTLY));
13 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE, 15 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE,
14 ExtensionIconSet::MATCH_BIGGER)); 16 ExtensionIconSet::MATCH_BIGGER));
15 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE, 17 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE,
16 ExtensionIconSet::MATCH_SMALLER)); 18 ExtensionIconSet::MATCH_SMALLER));
17 EXPECT_TRUE(icons.map().empty()); 19 EXPECT_TRUE(icons.map().empty());
18 20
19 icons.Add(ExtensionIconSet::EXTENSION_ICON_LARGE, "large.png"); 21 icons.Add(ExtensionIconSet::EXTENSION_ICON_LARGE, "large.png");
20 EXPECT_EQ("large.png", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE, 22 EXPECT_EQ("large.png", icons.Get(ExtensionIconSet::EXTENSION_ICON_LARGE,
(...skipping 22 matching lines...) Expand all
43 ExtensionIconSet::MATCH_SMALLER)); 45 ExtensionIconSet::MATCH_SMALLER));
44 EXPECT_EQ("large.png", icons.Get(ExtensionIconSet::EXTENSION_ICON_MEDIUM, 46 EXPECT_EQ("large.png", icons.Get(ExtensionIconSet::EXTENSION_ICON_MEDIUM,
45 ExtensionIconSet::MATCH_BIGGER)); 47 ExtensionIconSet::MATCH_BIGGER));
46 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_BITTY, 48 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_BITTY,
47 ExtensionIconSet::MATCH_SMALLER)); 49 ExtensionIconSet::MATCH_SMALLER));
48 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_GIGANTOR, 50 EXPECT_EQ("", icons.Get(ExtensionIconSet::EXTENSION_ICON_GIGANTOR,
49 ExtensionIconSet::MATCH_BIGGER)); 51 ExtensionIconSet::MATCH_BIGGER));
50 } 52 }
51 53
52 TEST(ExtensionIconSet, Values) { 54 TEST(ExtensionIconSet, Values) {
53 ExtensionIconSet icons; 55 ExtensionIconSet icons(ExtensionIconSet::ICON_SET_MANIFEST_ICONS);
54 EXPECT_FALSE(icons.ContainsPath("foo")); 56 EXPECT_FALSE(icons.ContainsPath("foo"));
55 57
56 icons.Add(ExtensionIconSet::EXTENSION_ICON_BITTY, "foo"); 58 icons.Add(ExtensionIconSet::EXTENSION_ICON_BITTY, "foo");
57 icons.Add(ExtensionIconSet::EXTENSION_ICON_GIGANTOR, "bar"); 59 icons.Add(ExtensionIconSet::EXTENSION_ICON_GIGANTOR, "bar");
58 60
59 EXPECT_TRUE(icons.ContainsPath("foo")); 61 EXPECT_TRUE(icons.ContainsPath("foo"));
60 EXPECT_TRUE(icons.ContainsPath("bar")); 62 EXPECT_TRUE(icons.ContainsPath("bar"));
61 EXPECT_FALSE(icons.ContainsPath("baz")); 63 EXPECT_FALSE(icons.ContainsPath("baz"));
62 EXPECT_FALSE(icons.ContainsPath("")); 64 EXPECT_FALSE(icons.ContainsPath(""));
63 65
64 icons.Clear(); 66 icons.Clear();
65 EXPECT_FALSE(icons.ContainsPath("foo")); 67 EXPECT_FALSE(icons.ContainsPath("foo"));
66 } 68 }
67 69
68 TEST(ExtensionIconSet, FindSize) { 70 TEST(ExtensionIconSet, FindSize) {
69 ExtensionIconSet icons; 71 ExtensionIconSet icons(ExtensionIconSet::ICON_SET_MANIFEST_ICONS);
70 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID, 72 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID,
71 icons.GetIconSizeFromPath("foo")); 73 icons.GetIconSizeFromPath("foo"));
72 74
73 icons.Add(ExtensionIconSet::EXTENSION_ICON_BITTY, "foo"); 75 icons.Add(ExtensionIconSet::EXTENSION_ICON_BITTY, "foo");
74 icons.Add(ExtensionIconSet::EXTENSION_ICON_GIGANTOR, "bar"); 76 icons.Add(ExtensionIconSet::EXTENSION_ICON_GIGANTOR, "bar");
75 77
76 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_BITTY, 78 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_BITTY,
77 icons.GetIconSizeFromPath("foo")); 79 icons.GetIconSizeFromPath("foo"));
78 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_GIGANTOR, 80 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_GIGANTOR,
79 icons.GetIconSizeFromPath("bar")); 81 icons.GetIconSizeFromPath("bar"));
80 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID, 82 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID,
81 icons.GetIconSizeFromPath("baz")); 83 icons.GetIconSizeFromPath("baz"));
82 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID, 84 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID,
83 icons.GetIconSizeFromPath("")); 85 icons.GetIconSizeFromPath(""));
84 86
85 icons.Clear(); 87 icons.Clear();
86 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID, 88 EXPECT_EQ(ExtensionIconSet::EXTENSION_ICON_INVALID,
87 icons.GetIconSizeFromPath("foo")); 89 icons.GetIconSizeFromPath("foo"));
88 } 90 }
91
92 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698