chrome/browser/ui/tab_contents/tab_contents.h - Issue 10837363: Introduce AutofillClient and use it to get rid of PasswordManager dependency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_contents/tab_contents.h

Issue 10837363: Introduce AutofillClient and use it to get rid of PasswordManager dependency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/plugin_infobar_delegates.cc ('K') | « chrome/browser/plugin_infobar_delegates.cc ('k') | chrome/browser/ui/tab_contents/tab_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_contents/tab_contents.h

diff --git a/chrome/browser/ui/tab_contents/tab_contents.h b/chrome/browser/ui/tab_contents/tab_contents.h

index c9f4f79d8426102733ff462f033335aad070147f..eb95200b709d97e67e3d3c26302444cf98dd7837 100644

--- a/chrome/browser/ui/tab_contents/tab_contents.h

+++ b/chrome/browser/ui/tab_contents/tab_contents.h

@@ -19,6 +19,7 @@ class AutofillExternalDelegate;

class AutomationTabHelper;

class BlockedContentTabHelper;

class BookmarkTabHelper;

+class ChromeAutofillClient;

class ConstrainedWindowTabHelper;

class CoreTabHelper;

class ExternalProtocolObserver;

@@ -268,6 +269,7 @@ class TabContents : public content::WebContentsObserver {

scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;

scoped_refptr<AutofillManager> autofill_manager_;

+ scoped_ptr<ChromeAutofillClient> autofill_client_;

Ilya Sherman 2012/08/22 03:38:03 Why not have the AutofillManager own the client?

Ilya Sherman 2012/08/22 03:39:09 Or, alternately, have the client (host?) own the m

scoped_ptr<AutofillExternalDelegate> autofill_external_delegate_;

scoped_ptr<AutomationTabHelper> automation_tab_helper_;

scoped_ptr<BlockedContentTabHelper> blocked_content_tab_helper_;

« chrome/browser/plugin_infobar_delegates.cc ('K') | « chrome/browser/plugin_infobar_delegates.cc ('k') | chrome/browser/ui/tab_contents/tab_contents.cc » ('j') | no next file with comments »