Introduce AutofillClient and use it to get rid of PasswordManager dependency.

chrome/browser/ui/tab_contents/tab_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_
 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/property_bag.h"
 #include "content/public/browser/web_contents_observer.h"
 
 class AlternateErrorPageTabObserver;
 class AutocompleteHistoryManager;
 class AutofillManager;
 class AutofillExternalDelegate;
 class AutomationTabHelper;
 class BlockedContentTabHelper;
 class BookmarkTabHelper;
+class ChromeAutofillClient;
 class ConstrainedWindowTabHelper;
 class CoreTabHelper;
 class ExternalProtocolObserver;
 class FaviconTabHelper;
 class FindTabHelper;
 class HistoryTabHelper;
 class HungPluginTabHelper;
 class InfoBarTabHelper;
 class MetroPinTabHelper;
 class NavigationMetricsRecorder;
@@ skipping 229 matching lines @@
   // Used to retrieve this object from |web_contents_|, which is placed in
   // its property bag to avoid adding additional interfaces.
   static base::PropertyAccessor<TabContents*>* property_accessor();
 
   // Tab Helpers ---------------------------------------------------------------
   // (These provide API for callers and have a getter function listed in the
   // "Tab Helpers" section in the member functions area, above.)
 
   scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
   scoped_refptr<AutofillManager> autofill_manager_;
+  scoped_ptr<ChromeAutofillClient> autofill_client_;

[Ilya Sherman, 2012/08/22 03:38:03]

Why not have the AutofillManager own the client?

[Ilya Sherman, 2012/08/22 03:39:09]

Or, alternately, have the client (host?) own the manager.  It just seems odd to
have both be members of TabContents.

   scoped_ptr<AutofillExternalDelegate> autofill_external_delegate_;
   scoped_ptr<AutomationTabHelper> automation_tab_helper_;
   scoped_ptr<BlockedContentTabHelper> blocked_content_tab_helper_;
   scoped_ptr<BookmarkTabHelper> bookmark_tab_helper_;
   scoped_ptr<chrome_browser_net::LoadTimeStatsTabHelper>
   load_time_stats_tab_helper_;
 #if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)
   scoped_ptr<captive_portal::CaptivePortalTabHelper> captive_portal_tab_helper_;
 #endif
   scoped_ptr<ConstrainedWindowTabHelper> constrained_window_tab_helper_;
@@ skipping 62 matching lines @@
 
   // The supporting objects need to outlive the WebContents dtor (as they may
   // be called upon during its execution). As a result, this must come last
   // in the list.
   scoped_ptr<content::WebContents> web_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(TabContents);
 };
 
 #endif  // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_H_