Persist browserAction settings to the extension StateStore.

chrome/common/extensions/extension_action.h

Index: chrome/common/extensions/extension_action.h
diff --git a/chrome/common/extensions/extension_action.h b/chrome/common/extensions/extension_action.h
index 5fc860fee53e6f6ec19de3d56e8579039c2c7186..edba1c126e3faa4840cbf7e208e14360f67c6d90 100644
--- a/chrome/common/extensions/extension_action.h
+++ b/chrome/common/extensions/extension_action.h
@@ -132,6 +132,9 @@ class ExtensionAction {
   std::vector<std::string>* icon_paths() { return &icon_paths_; }
   const std::vector<std::string>* icon_paths() const { return &icon_paths_; }
 
+  bool defaults_have_changed() const { return defaults_have_changed_; }
+  void set_defaults_have_changed(bool value) { defaults_have_changed_ = value; }
+
   // Set the url which the popup will load when the user clicks this action's
   // icon.  Setting an empty URL will disable the popup for a given tab.
   void SetPopupUrl(int tab_id, const GURL& url);
@@ -317,6 +320,10 @@ class ExtensionAction {
   // Saves the arguments from CacheIcon() calls.
   std::map<std::string, gfx::Image> path_to_icon_cache_;
 
+  // True if the ExtensionAction's defaults have changed from what was

[Yoyo Zhou, 2012/08/08 01:21:06]

Isn't it that the action has changed its foobar from its defaults? You can't
change the defaults.

If so, this name doesn't totally make sense.

[Matt Perry, 2012/08/08 01:40:08]

"default" is sort of an overloaded term here. I'm referring to the settings for
kDefaultTabId. But I realize now that this variable doesn't actually reflect
that, so I'll just rename it to "has_changed_"

+  // specified in the manifest.
+  bool defaults_have_changed_;
+
   DISALLOW_COPY_AND_ASSIGN(ExtensionAction);
 };