Persist browserAction settings to the extension StateStore.

chrome/common/extensions/extension_action.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_ACTION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_ACTION_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 114 matching lines @@
   Type action_type() const { return action_type_; }
 
   // action id -- only used with legacy page actions API
   std::string id() const { return id_; }
   void set_id(const std::string& id) { id_ = id; }
 
   // static icon paths from manifest -- only used with legacy page actions API.
   std::vector<std::string>* icon_paths() { return &icon_paths_; }
   const std::vector<std::string>* icon_paths() const { return &icon_paths_; }
 
+  bool defaults_have_changed() const { return defaults_have_changed_; }
+  void set_defaults_have_changed(bool value) { defaults_have_changed_ = value; }
+
   // Set the url which the popup will load when the user clicks this action's
   // icon.  Setting an empty URL will disable the popup for a given tab.
   void SetPopupUrl(int tab_id, const GURL& url);
 
   // Use HasPopup() to see if a popup should be displayed.
   bool HasPopup(int tab_id) const;
 
   // Get the URL to display in a popup.
   GURL GetPopupUrl(int tab_id) const;
 
@@ skipping 165 matching lines @@
   // needed for compat with an older version of the page actions API.
   std::string id_;
 
   // A list of paths to icons this action might show. This is needed to support
   // the legacy setIcon({iconIndex:...} method of the page actions API.
   std::vector<std::string> icon_paths_;
 
   // Saves the arguments from CacheIcon() calls.
   std::map<std::string, gfx::Image> path_to_icon_cache_;
 
+  // True if the ExtensionAction's defaults have changed from what was

[Yoyo Zhou, 2012/08/08 01:21:06]

Isn't it that the action has changed its foobar from its defaults? You can't
change the defaults.

If so, this name doesn't totally make sense.

[Matt Perry, 2012/08/08 01:40:08]

"default" is sort of an overloaded term here. I'm referring to the settings for
kDefaultTabId. But I realize now that this variable doesn't actually reflect
that, so I'll just rename it to "has_changed_"

+  // specified in the manifest.
+  bool defaults_have_changed_;
+
   DISALLOW_COPY_AND_ASSIGN(ExtensionAction);
 };
 
 template<>
 struct ExtensionAction::ValueTraits<int> {
   static int CreateEmpty() {
     return -1;
   }
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_ACTION_H_