Fix memory leak in WebsiteSettingsTest.ShowInfoBar.

Fix memory leak in WebsiteSettingsTest.ShowInfoBar.


BUG=140041
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149635

[markusheintz_, 2012-08-02 11:14:27]

Sorry for the delay. Here we go. Please review this CL.
Thanks

[Timur Iskhodzhanov, 2012-08-02 11:18:09]

LGTM with possible suggestion.

Please note that I'm not very familiar with the Chromium codebase and
conventions.

Also, I'm not sure my LGTM is enough in chrome/browser/ui.
That said, probably you'll need someone else to review too.

http://codereview.chromium.org/10837049/diff/5001/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings_unittest.cc (right):

http://codereview.chromium.org/10837049/diff/5001/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings_unittest.cc:345:
InfoBarDelegate* delegate = infobar_tab_helper()->GetInfoBarDelegateAt(0);
is there anything like auto_ptr/scoped_ptr which is appropriate here?

[markusheintz_, 2012-08-02 12:55:38]

No worries your LGTM is sufficient as I am  the owner of this code.

I added battre to double check the coding style.

@Dominic: Could you review this CL please? Thanks a lot.

http://codereview.chromium.org/10837049/diff/5001/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings_unittest.cc (right):

http://codereview.chromium.org/10837049/diff/5001/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings_unittest.cc:345:
InfoBarDelegate* delegate = infobar_tab_helper()->GetInfoBarDelegateAt(0);
On 2012/08/02 11:18:09, Timur Iskhodzhanov wrote:
> is there anything like auto_ptr/scoped_ptr which is appropriate here?

I guess you are right it's probably better to use a scoped_ptr. And I think a
small comment also doesn't hurt.

[battre, 2012-08-02 14:24:09]

lgtm

[commit-bot: I haz the power, 2012-08-02 14:32:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10837049/4005

[commit-bot: I haz the power, 2012-08-02 16:02:40]

Change committed as 149635