Fix memory leak in WebsiteSettingsTest.ShowInfoBar.

chrome/browser/ui/website_settings/website_settings_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/website_settings/website_settings.h"
 
 #include "base/at_exit.h"
 #include "base/message_loop.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
+#include "chrome/browser/infobars/infobar_delegate.h"
 #include "chrome/browser/infobars/infobar_tab_helper.h"
 #include "chrome/browser/ui/website_settings/website_settings_ui.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/content_settings_types.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/browser/cert_store.h"
 #include "content/public/common/ssl_status.h"
 #include "content/public/test/test_browser_thread.h"
 #include "net/base/cert_status_flags.h"
@@ skipping 311 matching lines @@
 }
 
 TEST_F(WebsiteSettingsTest, ShowInfoBar) {
   SetDefaultUIExpectations(mock_ui());
   EXPECT_EQ(0u, infobar_tab_helper()->infobar_count());
   website_settings()->OnSitePermissionChanged(
       CONTENT_SETTINGS_TYPE_GEOLOCATION, CONTENT_SETTING_ALLOW);
   website_settings()->OnUIClosing();
   EXPECT_EQ(1u, infobar_tab_helper()->infobar_count());
 
-  infobar_tab_helper()->RemoveInfoBar(
-      infobar_tab_helper()->GetInfoBarDelegateAt(0));
+  InfoBarDelegate* delegate = infobar_tab_helper()->GetInfoBarDelegateAt(0);

[Timur Iskhodzhanov, 2012/08/02 11:18:09]

is there anything like auto_ptr/scoped_ptr which is appropriate here?

[markusheintz_, 2012/08/02 12:55:38]

I guess you are right it's probably better to use a scoped_ptr. And I think a
small comment also doesn't hurt.

+  infobar_tab_helper()->RemoveInfoBar(delegate);
+  delete delegate;
 }