tools/json_schema_compiler/util.h - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/util.h

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/util.h

diff --git a/tools/json_schema_compiler/util.h b/tools/json_schema_compiler/util.h

index 61148c616a4e6ac2b268b61feb25331c1f50dde3..509b0dc1a772a0a9aca503052d70f2446f7a3b8a 100644

--- a/tools/json_schema_compiler/util.h

+++ b/tools/json_schema_compiler/util.h

@@ -34,7 +34,7 @@ bool GetItemFromList(const ListValue& from, int index,

// This template is used for types generated by tools/json_schema_compiler.

template<class T>

bool GetItemFromList(const ListValue& from, int index, linked_ptr<T>* out) {

- DictionaryValue* dict;

+ const DictionaryValue* dict;

if (!from.GetDictionary(index, &dict))

return false;

scoped_ptr<T> obj(new T());

« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | tools/json_schema_compiler/util.cc » ('j') | no next file with comments »