tools/json_schema_compiler/cc_generator.py - Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cc_generator.py

Issue 10837044: Correct const accessors in base/values.(h|cc), Part II (ListValue) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: David's comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/cc_generator.py

diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py

index 68751871ced41b8024e9e2067e5e863dfbd54c31..d09d32584754bfee863b2672e1a038951b3eaa5a 100644

--- a/tools/json_schema_compiler/cc_generator.py

+++ b/tools/json_schema_compiler/cc_generator.py

@@ -420,7 +420,7 @@ class CCGenerator(object):

failure_value = 'scoped_ptr<Params>()'

c.Append()

value_var = param.unix_name + '_value'

- (c.Append('base::Value* %(value_var)s = NULL;')

+ (c.Append('const base::Value* %(value_var)s = NULL;')

.Append('if (args.Get(%(i)s, &%(value_var)s) &&\n'

' !%(value_var)s->IsType(base::Value::TYPE_NULL))')

.Sblock('{')

« no previous file with comments | « sync/protocol/proto_value_conversions_unittest.cc ('k') | tools/json_schema_compiler/util.h » ('j') | no next file with comments »