Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: compiler/java/com/google/dart/compiler/parser/DartParser.java

Issue 10836252: Finalize support for new getter syntax, per issue 3607 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/parser/DartParser.java
===================================================================
--- compiler/java/com/google/dart/compiler/parser/DartParser.java (revision 10680)
+++ compiler/java/com/google/dart/compiler/parser/DartParser.java (working copy)
@@ -1372,6 +1372,7 @@
if (peekPseudoKeyword(0, GETTER_KEYWORD)
|| peekPseudoKeyword(0, SETTER_KEYWORD)) {
+ boolean isGetter = peekPseudoKeyword(0, GETTER_KEYWORD);
next();
// Using 'get' or 'set' as a field name is valid
if (peek(0).equals(Token.SEMICOLON) || peek(0).equals(Token.ASSIGN)) {
@@ -1382,7 +1383,7 @@
return true;
}
// normal case: get foo (
- if (peek(0).equals(Token.IDENTIFIER) && peek(1).equals(Token.LPAREN)) {
+ if (peek(0).equals(Token.IDENTIFIER) && (isGetter || peek(1).equals(Token.LPAREN))) {
return true;
}
return false;
@@ -1557,11 +1558,6 @@
// accepted, but eventually parameters should be disallowed.
parameters = new ArrayList<DartParameter>();
} else {
- if (modifiers.isSetter()) {
- // TODO: For now we optionally allow an equal sign before the formal parameter list, but
- // eventually it should be required.
- optional(Token.ASSIGN);
- }
parameters = parseFormalParameterList();
}
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698