Finalize support for new getter syntax, per issue 3607

compiler/java/com/google/dart/compiler/parser/DartParser.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.parser;
 
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.collect.ImmutableSet;
 import com.google.common.io.CharStreams;
 import com.google.dart.compiler.DartCompilationError;
@@ skipping 1354 matching lines @@
           // operator []= (
           if (peek(2).equals(Token.ASSIGN) && peek(3).equals(Token.LPAREN)) {
             return true;
           }
         }
         return false;
       }
 
       if (peekPseudoKeyword(0, GETTER_KEYWORD)
           || peekPseudoKeyword(0, SETTER_KEYWORD)) {
+        boolean isGetter = peekPseudoKeyword(0, GETTER_KEYWORD);
         next();
         // Using 'get' or 'set' as a field name is valid
         if (peek(0).equals(Token.SEMICOLON) || peek(0).equals(Token.ASSIGN)) {
           return false;
         }
         // Using 'get' or 'set' as a method name is valid (but discouraged)
         if (peek(0).equals(Token.LPAREN)) {
           return true;
         }
         // normal case:  get foo (
-        if (peek(0).equals(Token.IDENTIFIER) && peek(1).equals(Token.LPAREN)) {
+        if (peek(0).equals(Token.IDENTIFIER) && (isGetter || peek(1).equals(Token.LPAREN))) {
           return true;
         }
         return false;
       }
 
       consume(Token.IDENTIFIER);
 
       if (peek(0).equals(Token.PERIOD) && peek(1).equals(Token.IDENTIFIER)) {
         consume(Token.PERIOD);
         consume(Token.IDENTIFIER);
@@ skipping 154 matching lines @@
       done(null);
     }
 
     // Parse the parameters definitions.
     List<DartParameter> parameters;
     if (modifiers.isGetter() && peek(0) != Token.LPAREN) {
       // TODO: For now the parameters are optional so that both the old and new style will be
       // accepted, but eventually parameters should be disallowed.
       parameters = new ArrayList<DartParameter>();
     } else {
-      if (modifiers.isSetter()) {
-        // TODO: For now we optionally allow an equal sign before the formal parameter list, but
-        // eventually it should be required.
-        optional(Token.ASSIGN);
-      }
       parameters = parseFormalParameterList();
     }
 
     if (arity != -1) {
       if (parameters.size() != arity) {
         reportError(position(), ParserErrorCode.ILLEGAL_NUMBER_OF_PARAMETERS);
       }
       // In methods with required arity each parameter is required.
       for (DartParameter parameter : parameters) {
         if (parameter.getModifiers().isNamed()) {
@@ skipping 3289 matching lines @@
   private void reportError(DartNode node, ErrorCode errorCode, Object... arguments) {
     if (node != null) {
       reportError(new DartCompilationError(node, errorCode, arguments));
     }
   }
 
   private boolean currentlyParsingToplevel() {
     return   !(isParsingInterface || isTopLevelAbstract || isParsingClass);
   }
 }