Turned job_factory into a pure virtual class

net/url_request/url_request_job_factory.h

Index: net/url_request/url_request_job_factory.h
diff --git a/net/url_request/url_request_job_factory.h b/net/url_request/url_request_job_factory.h
index 746e9486894546b36f8d9fb20a5ffdaec8109bb7..9f21c6140f3e7c028ff58f01a293d3ec8bab373a 100644
--- a/net/url_request/url_request_job_factory.h
+++ b/net/url_request/url_request_job_factory.h
@@ -71,34 +71,29 @@ class NET_EXPORT URLRequestJobFactory
   // Sets the ProtocolHandler for a scheme. Returns true on success, false on

[erikwright (departed), 2012/08/16 15:49:01]

TODO remove from the interface.

[shalev, 2012/08/16 18:40:39]

Done.

   // failure (a ProtocolHandler already exists for |scheme|). On success,
   // URLRequestJobFactory takes ownership of |protocol_handler|.
-  bool SetProtocolHandler(const std::string& scheme,
-                          ProtocolHandler* protocol_handler);
+  virtual bool SetProtocolHandler(const std::string& scheme,
+                                  ProtocolHandler* protocol_handler) = 0;
 
   // Takes ownership of |interceptor|. Adds it to the end of the Interceptor
   // list.

[erikwright (departed), 2012/08/16 15:49:01]

TODO remove from the interface.

[shalev, 2012/08/16 18:40:39]

Done.

-  void AddInterceptor(Interceptor* interceptor);
+  virtual void AddInterceptor(Interceptor* interceptor) = 0;
 
-  URLRequestJob* MaybeCreateJobWithInterceptor(URLRequest* request) const;
+  virtual URLRequestJob* MaybeCreateJobWithInterceptor(
+      URLRequest* request) const = 0;
 
-  URLRequestJob* MaybeCreateJobWithProtocolHandler(const std::string& scheme,
-                                                   URLRequest* request) const;
+  virtual URLRequestJob* MaybeCreateJobWithProtocolHandler(
+      const std::string& scheme, URLRequest* request) const = 0;
 
-  URLRequestJob* MaybeInterceptRedirect(const GURL& location,
-                                        URLRequest* request) const;
+  virtual URLRequestJob* MaybeInterceptRedirect(
+      const GURL& location, URLRequest* request) const = 0;
 
-  URLRequestJob* MaybeInterceptResponse(URLRequest* request) const;
+  virtual URLRequestJob* MaybeInterceptResponse(URLRequest* request) const = 0;
 
-  bool IsHandledProtocol(const std::string& scheme) const;
+  virtual bool IsHandledProtocol(const std::string& scheme) const = 0;
 
-  bool IsHandledURL(const GURL& url) const;
+  virtual bool IsHandledURL(const GURL& url) const = 0;
 
  private:
-  typedef std::map<std::string, ProtocolHandler*> ProtocolHandlerMap;
-  typedef std::vector<Interceptor*> InterceptorList;
-
-  ProtocolHandlerMap protocol_handler_map_;
-  InterceptorList interceptors_;
-
   DISALLOW_COPY_AND_ASSIGN(URLRequestJobFactory);
 };