Turned job_factory into a pure virtual class

net/url_request/url_request_job_factory.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_
 #define NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_
 
 #include <map>

[erikwright (departed), 2012/08/16 15:49:01]

don't need map or vector

[shalev, 2012/08/16 18:40:39]

Done.

 #include <string>
 #include <vector>
 #include "base/basictypes.h"
 #include "base/threading/non_thread_safe.h"
 #include "net/base/net_export.h"
 
 class GURL;
 
 namespace net {
 
 class URLRequest;
 class URLRequestJob;
 
 class NET_EXPORT URLRequestJobFactory
     : NON_EXPORTED_BASE(public base::NonThreadSafe) {

[erikwright (departed), 2012/08/16 15:49:01]

#include "base/compiler_specific.h" for NON_EXPORTED_BASE

[shalev, 2012/08/16 18:40:39]

Done.

  public:
   class NET_EXPORT ProtocolHandler {
    public:
     virtual ~ProtocolHandler();
 
     virtual URLRequestJob* MaybeCreateJob(URLRequest* request) const = 0;
   };
 
   class NET_EXPORT Interceptor {
    public:
@@ skipping 25 matching lines @@
     virtual URLRequestJob* MaybeInterceptResponse(
         URLRequest* request) const = 0;
 
     // Returns true if this interceptor handles requests for URLs with the
     // given protocol. Returning false does not imply that this interceptor
     // can't or won't handle requests with the given protocol.
     virtual bool WillHandleProtocol(const std::string& protocol) const;
   };
 
   URLRequestJobFactory();
   ~URLRequestJobFactory();

[erikwright (departed), 2012/08/16 15:49:01]

virtual

[shalev, 2012/08/16 18:40:39]

Done.

 
   // Sets the ProtocolHandler for a scheme. Returns true on success, false on

[erikwright (departed), 2012/08/16 15:49:01]

TODO remove from the interface.

[shalev, 2012/08/16 18:40:39]

Done.

   // failure (a ProtocolHandler already exists for |scheme|). On success,
   // URLRequestJobFactory takes ownership of |protocol_handler|.
-  bool SetProtocolHandler(const std::string& scheme,
-                          ProtocolHandler* protocol_handler);
+  virtual bool SetProtocolHandler(const std::string& scheme,
+                                  ProtocolHandler* protocol_handler) = 0;
 
   // Takes ownership of |interceptor|. Adds it to the end of the Interceptor
   // list.

[erikwright (departed), 2012/08/16 15:49:01]

TODO remove from the interface.

[shalev, 2012/08/16 18:40:39]

Done.

-  void AddInterceptor(Interceptor* interceptor);
+  virtual void AddInterceptor(Interceptor* interceptor) = 0;
 
-  URLRequestJob* MaybeCreateJobWithInterceptor(URLRequest* request) const;
+  virtual URLRequestJob* MaybeCreateJobWithInterceptor(
+      URLRequest* request) const = 0;
 
-  URLRequestJob* MaybeCreateJobWithProtocolHandler(const std::string& scheme,
-                                                   URLRequest* request) const;
+  virtual URLRequestJob* MaybeCreateJobWithProtocolHandler(
+      const std::string& scheme, URLRequest* request) const = 0;
 
-  URLRequestJob* MaybeInterceptRedirect(const GURL& location,
-                                        URLRequest* request) const;
+  virtual URLRequestJob* MaybeInterceptRedirect(
+      const GURL& location, URLRequest* request) const = 0;
 
-  URLRequestJob* MaybeInterceptResponse(URLRequest* request) const;
+  virtual URLRequestJob* MaybeInterceptResponse(URLRequest* request) const = 0;
 
-  bool IsHandledProtocol(const std::string& scheme) const;
+  virtual bool IsHandledProtocol(const std::string& scheme) const = 0;
 
-  bool IsHandledURL(const GURL& url) const;
+  virtual bool IsHandledURL(const GURL& url) const = 0;
 
  private:
-  typedef std::map<std::string, ProtocolHandler*> ProtocolHandlerMap;
-  typedef std::vector<Interceptor*> InterceptorList;
-
-  ProtocolHandlerMap protocol_handler_map_;
-  InterceptorList interceptors_;
-
   DISALLOW_COPY_AND_ASSIGN(URLRequestJobFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_JOB_FACTORY_H_