Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/nacl_host/nacl_browser.cc

Issue 10836220: Eliminate the 'build_ppapi_ipc_proxy_untrusted' build flag for untrusted PPAPI proxy builds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/nacl_browser.cc
===================================================================
--- chrome/browser/nacl_host/nacl_browser.cc (revision 151201)
+++ chrome/browser/nacl_host/nacl_browser.cc (working copy)
@@ -4,6 +4,7 @@
#include "chrome/browser/nacl_host/nacl_browser.h"
+#include "base/command_line.h"
#include "base/message_loop.h"
#include "base/metrics/histogram.h"
#include "base/path_service.h"
@@ -12,6 +13,7 @@
#include "build/build_config.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_paths_internal.h"
+#include "chrome/common/chrome_switches.h"
#include "content/public/browser/browser_thread.h"
namespace {
@@ -31,8 +33,9 @@
};
// Determine the name of the IRT file based on the architecture.
-#define NACL_IRT_FILE_NAME(arch_string) \
- (FILE_PATH_LITERAL("nacl_irt_") \
+#define NACL_IRT_FILE_NAME(type, arch_string) \
+ (FILE_PATH_LITERAL(type) \
+ FILE_PATH_LITERAL("_") \
FILE_PATH_LITERAL(arch_string) \
FILE_PATH_LITERAL(".nexe"))
@@ -46,7 +49,14 @@
#else
bool is64 = false;
#endif
- return is64 ? NACL_IRT_FILE_NAME("x86_64") : NACL_IRT_FILE_NAME("x86_32");
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableNaClIPCProxy)) {
+ return is64 ? NACL_IRT_FILE_NAME("nacl_chrome_irt", "x86_64") :
Mark Seaborn 2012/08/14 01:12:05 Chrome's existing irt.nexe is Chrome-specific too,
dmichael (off chromium) 2012/08/14 17:03:31 Bill and I had talked about that name, too. It wou
bbudge 2012/08/14 18:35:18 'nacl_ipc_irt' was both David's and my first idea.
+ NACL_IRT_FILE_NAME("nacl_chrome_irt", "x86_32");
+ } else {
+ return is64 ? NACL_IRT_FILE_NAME("nacl_irt", "x86_64") :
+ NACL_IRT_FILE_NAME("nacl_irt", "x86_32");
+ }
#elif defined(ARCH_CPU_ARMEL)
// TODO(mcgrathr): Eventually we'll need to distinguish arm32 vs thumb2.
// That may need to be based on the actual nexe rather than a static

Powered by Google App Engine
This is Rietveld 408576698