Eliminate the 'build_ppapi_ipc_proxy_untrusted' build flag for untrusted PPAPI proxy builds.

chrome/browser/nacl_host/nacl_browser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/nacl_host/nacl_browser.h"
 
+#include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/pickle.h"
 #include "base/win/windows_version.h"
 #include "build/build_config.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_paths_internal.h"
+#include "chrome/common/chrome_switches.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace {
 
 // An arbitrary delay to coalesce multiple writes to the cache.
 const int kValidationCacheCoalescingTimeMS = 6000;
 const char kValidationCacheSequenceName[] = "NaClValidationCache";
 const FilePath::CharType kValidationCacheFileName[] =
     FILE_PATH_LITERAL("nacl_validation_cache.bin");
 
 const bool kValidationCacheEnabledByDefault = true;
 
 enum ValidationCacheStatus {
   CACHE_MISS = 0,
   CACHE_HIT,
   CACHE_MAX
 };
 
 // Determine the name of the IRT file based on the architecture.
-#define NACL_IRT_FILE_NAME(arch_string) \
-  (FILE_PATH_LITERAL("nacl_irt_")       \
+#define NACL_IRT_FILE_NAME(type, arch_string) \
+  (FILE_PATH_LITERAL(type)              \
+   FILE_PATH_LITERAL("_")               \
    FILE_PATH_LITERAL(arch_string)       \
    FILE_PATH_LITERAL(".nexe"))
 
 const FilePath::StringType NaClIrtName() {
 #if defined(ARCH_CPU_X86_FAMILY)
 #if defined(ARCH_CPU_X86_64)
   bool is64 = true;
 #elif defined(OS_WIN)
   bool is64 = (base::win::OSInfo::GetInstance()->wow64_status() ==
                base::win::OSInfo::WOW64_ENABLED);
 #else
   bool is64 = false;
 #endif
-  return is64 ? NACL_IRT_FILE_NAME("x86_64") : NACL_IRT_FILE_NAME("x86_32");
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableNaClIPCProxy)) {
+    return is64 ? NACL_IRT_FILE_NAME("nacl_chrome_irt", "x86_64") :

[Mark Seaborn, 2012/08/14 01:12:05]

Chrome's existing irt.nexe is Chrome-specific too, so this name could be
confusing.  How about "nacl_ipc_proxy_irt"?

[dmichael (off chromium), 2012/08/14 17:03:31]

Bill and I had talked about that name, too. It would be nice to have a name that
we like _after_ the switch too (rather than renaming the new IRT to the old IRT
name when we pull the switch). nacl_chrome_irt seemed like a good compromise in
the absence of any perfect name.

[bbudge, 2012/08/14 18:35:18]

'nacl_ipc_irt' was both David's and my first idea. Since it's yours too Mark,
perhaps I'm over-thinking this. Done.

+                  NACL_IRT_FILE_NAME("nacl_chrome_irt", "x86_32");
+  } else {
+    return is64 ? NACL_IRT_FILE_NAME("nacl_irt", "x86_64") :
+                  NACL_IRT_FILE_NAME("nacl_irt", "x86_32");
+  }
 #elif defined(ARCH_CPU_ARMEL)
   // TODO(mcgrathr): Eventually we'll need to distinguish arm32 vs thumb2.
   // That may need to be based on the actual nexe rather than a static
   // choice, which would require substantial refactoring.
   return NACL_IRT_FILE_NAME("arm");

[Mark Seaborn, 2012/08/14 01:12:05]

You need to update the ARM case too.  It looks like the code would be cleaner if
you drop the macro and concatenate the architecture name at runtime.

[bbudge, 2012/08/14 18:35:18]

Done.

 #else
 #error Add support for your architecture to NaCl IRT file selection
 #endif
 }
 
 bool CheckEnvVar(const char* name, bool default_value) {
   bool result = default_value;
   const char* var = getenv(name);
   if (var && strlen(var) > 0) {
     result = var[0] != '0';
@@ skipping 323 matching lines @@
     // because it can degrade the responsiveness of the browser.
     // The task is sequenced so that multiple writes happen in order.
     content::BrowserThread::PostBlockingPoolSequencedTask(
         kValidationCacheSequenceName,
         FROM_HERE,
         base::Bind(WriteCache, validation_cache_file_path_,
                    base::Owned(pickle)));
   }
   validation_cache_is_modified_ = false;
 }