chrome/common/extensions/PRESUBMIT.py - Issue 10834214: Fix extension docs presubmit. One, not all, of the subdirs should have matching static docs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/PRESUBMIT.py

Issue 10834214: Fix extension docs presubmit. One, not all, of the subdirs should have matching static docs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/PRESUBMIT.py

diff --git a/chrome/common/extensions/PRESUBMIT.py b/chrome/common/extensions/PRESUBMIT.py

index 1ab0964dff072c4319d0f4b8ebc126b474a51a2b..46865d19148ea413d23171ceb86d27ce43e05718 100644

--- a/chrome/common/extensions/PRESUBMIT.py

+++ b/chrome/common/extensions/PRESUBMIT.py

@@ -147,9 +147,9 @@ def StaticDocBuilt(static_file, input_api):

"""

for subdir in [APPS_DIR, EXTENSIONS_DIR]:

generated_file = _FindFileInAlternateDir(static_file, subdir, input_api)

- if not _ChangesMatch(generated_file, static_file):

- return False

- return True

+ if _ChangesMatch(generated_file, static_file):

+ return True

+ return False

Joao da Silva 2012/08/08 09:11:50 I'll be wearing a brown bag over my head today ._.

def _FindFileInAlternateDir(affected_file, alt_dir, input_api):

"""Return an AffectFile for the file in |alt_dir| that corresponds to

« no previous file with comments | « no previous file | chrome/common/extensions/PRESUBMIT_test.py » ('j') | no next file with comments »