Fix extension docs presubmit. One, not all, of the subdirs should have matching static docs.

chrome/common/extensions/PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os.path  # for initializing constants
 
 # Directories that we run presubmit checks on.
 PRESUBMIT_PATH = os.path.normpath('chrome/common/extensions/PRESUBMIT.py')
 API_DIR = os.path.normpath('chrome/common/extensions/api')
 DOC_DIR = os.path.normpath('chrome/common/extensions/docs')
@@ skipping 129 matching lines @@
              IsStaticDoc(path, input_api) or
              IsSampleFile(path, input_api)
              for path in input_api.LocalPaths())
 
 def StaticDocBuilt(static_file, input_api):
   """Return True if the generated doc that corresponds to the |static_file|
   is also in this change. Both files must also contain matching changes.
   """
   for subdir in [APPS_DIR, EXTENSIONS_DIR]:
     generated_file = _FindFileInAlternateDir(static_file, subdir, input_api)
-    if not _ChangesMatch(generated_file, static_file):
-      return False
-  return True
+    if _ChangesMatch(generated_file, static_file):
+      return True
+  return False

[Joao da Silva, 2012/08/08 09:11:50]

I'll be wearing a brown bag over my head today ._.

 
 def _FindFileInAlternateDir(affected_file, alt_dir, input_api):
   """Return an AffectFile for the file in |alt_dir| that corresponds to
   |affected_file|.
 
   If the file does not exist in the is change, return None.
   """
   alt_path = _AlternateFilePath(affected_file.LocalPath(), alt_dir, input_api)
   for f in input_api.AffectedFiles():
     if f.LocalPath() == alt_path:
@@ skipping 57 matching lines @@
 def SampleZipped(sample_file, input_api):
   """Return True if the zipfile that should contain |sample_file| is in
   this change.
   """
   sample_path = sample_file.LocalPath()
   for af in input_api.AffectedFiles():
     root, ext = input_api.os_path.splitext(af.LocalPath())
     if ext == '.zip' and sample_path.startswith(root):
       return True
   return False