|
Integrate invalidation API into ChromeToMobileService.
Update chrome/browser/DEPS with new dependencies:
(google/cacheinvalidation and sync/notifier)
Observe Sync Notifier invalidation notifications:
(depend on this service for mobile list updates)
(refresh the device list on cloud print invalidation)
Remove RequestMobileListUpdate, timestamp, & account info:
(no longer needed with invalidation integration)
(just set command state and icon visibility w/HasMobiles)
Lazily init the access token, queue search/send operations:
(only get an access token as needed, add |task_queue_|)
Allow concurrent cloud print device search requests:
(handle user-triggered updates while fetching the list)
Misc cleanup (CloudPrintUrl handling, tests, etc.)
TODO(followup): Additional logging, tests, invalidation ack.
BUG= 102709, 137086
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152609
Total comments: 12
Total comments: 10
Total comments: 2
Total comments: 10
Total comments: 12
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+186 lines, -182 lines) |
Patch |
|
M |
chrome/browser/DEPS
|
View
|
1
2
3
4
5
6
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_to_mobile_service.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
8 chunks |
+29 lines, -20 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_to_mobile_service.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
|
13 chunks |
+119 lines, -120 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_to_mobile_service_factory.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_to_mobile_service_factory.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_to_mobile_service_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
2 chunks |
+13 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller.mm
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/chrome_to_mobile_bubble_controller_unittest.mm
|
View
|
1
2
3
4
5
6
7
8
9
|
7 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/gtk/location_bar_view_gtk.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/location_bar/location_bar_view.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
|
1 chunk |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/common/pref_names.h
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/common/pref_names.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
Total messages: 29 (0 generated)
|