chrome/browser/extensions/api/web_request/web_request_api_helpers.h - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_helpers.h

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.h

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.h b/chrome/browser/extensions/api/web_request/web_request_api_helpers.h

index cbe536b74fe513e4f487a046f5666c2c7df60ed5..ea748e44ccaa7bb0b72787982f03d431000c754d 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.h

+++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.h

@@ -91,7 +91,7 @@ base::ListValue* StringToCharList(const std::string& s);

// Converts a list of integer values between 0 and 255 into a string |*out|.

// Returns true if the conversion was successful.

-bool CharListToString(base::ListValue* list, std::string* out);

+bool CharListToString(const base::ListValue* list, std::string* out);

// The following functions calculate and return the modifications to requests

// commanded by extension handlers. All functions take the id of the extension