chrome/browser/extensions/api/web_request/web_request_api_helpers.cc - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_helpers.h ('k') | chrome/browser/extensions/event_listener_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

index fad5eda697033fb5f515ae973a43c7044fde9ddb..da746478eecb50346451326db360590858ce4909 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc

@@ -117,7 +117,7 @@ ListValue* StringToCharList(const std::string& s) {

return result;

}

-bool CharListToString(ListValue* list, std::string* out) {

+bool CharListToString(const ListValue* list, std::string* out) {

if (!list)

return false;

const size_t list_length = list->GetSize();