Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc
index e3d168a1b972feff341792f1ab2d85ec92f5fd00..10f1d581887ab328fd3bc0dbb4124f670d89b67c 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc
@@ -175,7 +175,7 @@ bool FromHeaderDictionary(const DictionaryValue* header_value,
return false;
}
} else if (header_value->HasKey(keys::kHeaderBinaryValueKey)) {
- ListValue* list = NULL;
+ const ListValue* list = NULL;
if (!header_value->GetList(keys::kHeaderBinaryValueKey, &list) ||
!helpers::CharListToString(list, value)) {
return false;
@@ -350,7 +350,7 @@ bool ExtensionWebRequestEventRouter::RequestFilter::InitFromValue(
for (DictionaryValue::key_iterator key = value.begin_keys();
key != value.end_keys(); ++key) {
if (*key == "urls") {
- ListValue* urls_value = NULL;
+ const ListValue* urls_value = NULL;
if (!value.GetList("urls", &urls_value))
return false;
for (size_t i = 0; i < urls_value->GetSize(); ++i) {
@@ -368,7 +368,7 @@ bool ExtensionWebRequestEventRouter::RequestFilter::InitFromValue(
urls.AddPattern(pattern);
}
} else if (*key == "types") {
- ListValue* types_value = NULL;
+ const ListValue* types_value = NULL;
if (!value.GetList("types", &types_value))
return false;
for (size_t i = 0; i < types_value->GetSize(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698