chrome/browser/ui/views/extensions/extension_dialog.cc - Issue 10833014: Coverity fixlet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog.cc

Issue 10833014: Coverity fixlet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Uploaded after rebasing. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/extension_dialog.cc

diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc

index e3aeb3d6d2331bb3780cb0f241b2fa9de5aabf8b..dec0bfaeedd4ca6268f979c9e3ec4e1aabe2e0ca 100644

--- a/chrome/browser/ui/views/extensions/extension_dialog.cc

+++ b/chrome/browser/ui/views/extensions/extension_dialog.cc

@@ -186,8 +186,10 @@ void ExtensionDialog::Close() {

void ExtensionDialog::MaybeFocusRenderView() {

views::FocusManager* focus_manager = GetWidget()->GetFocusManager();

+ DCHECK(focus_manager != NULL);

// Already there's a focused view, so no need to switch the focus.

- if (focus_manager && focus_manager->GetFocusedView())

+ if (focus_manager->GetFocusedView())

return;

content::RenderWidgetHostView* view = host()->render_view_host()->GetView();