chrome/browser/extensions/extension_info_map.cc - Issue 10833014: Coverity fixlet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_info_map.cc

Issue 10833014: Coverity fixlet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Uploaded after rebasing. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_info_map.cc

diff --git a/chrome/browser/extensions/extension_info_map.cc b/chrome/browser/extensions/extension_info_map.cc

index 39357c11e1ec20ed293ebd9599940c93253c61e4..3f9bb73c2056bead9e35a0dc9dc6f6ab40635a11 100644

--- a/chrome/browser/extensions/extension_info_map.cc

+++ b/chrome/browser/extensions/extension_info_map.cc

@@ -127,7 +127,9 @@ bool ExtensionInfoMap::SecurityOriginHasAPIPermission(

extensions::APIPermission::ID permission) const {

if (origin.SchemeIs(chrome::kExtensionScheme)) {

const std::string& id = origin.host();

- return extensions_.GetByID(id)->HasAPIPermission(permission) &&

+ const Extension* extension = extensions_.GetByID(id);

+ CHECK(extension != NULL);

+ return extension->HasAPIPermission(permission) &&

process_map_.Contains(id, process_id);

}