Run the WebView license checker on the android FYI builder

Run the WebView license checker on the android FYI builder

BUG=138921
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153194

[Steve Block, 2012-08-17 11:14:12]

Note that this is currently blocked on https://codereview.appspot.com/6443089

[Peter Beverloo, 2012-08-17 11:40:45]

I get the following output when running the tool locally. The
third_party/android and third_party/pylib seem genuine, and aren't being
addressed by CL 6443089. Since the return code is 1, I guess this will make the
builder turn red once this lands?

---

Got LicenseError "missing README.chromium or licenses.py SPECIAL_CASES entry"
while scanning third_party/android
Got LicenseError "missing README.chromium or licenses.py SPECIAL_CASES entry"
while scanning third_party/android_tools
Got LicenseError "missing README.chromium or licenses.py SPECIAL_CASES entry"
while scanning third_party/pylib
grep: ./native_client/toolchain/pnacl_linux_x86_64/newlib/sysroot/sys-include:
No such file or directory
The following files contain a third-party license but are not in a listed
third-party directory and are not whitelisted. You must add the following files
to the whitelist.
chrome/tools/test/reference_build/chrome_linux/resources/inspector/DevTools.js
chrome/tools/test/reference_build/chrome_linux/resources/inspector/auditsPanel.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/devTools.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/devtools.html
chrome/tools/test/reference_build/chrome_linux/resources/inspector/devtools_extension_api.js
chrome/tools/test/reference_build/chrome_linux/resources/inspector/elementsPanel.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/heapProfiler.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/indexedDBViews.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/navigatorView.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/networkPanel.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/panelEnablerView.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/profilesPanel.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/resourceView.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/resourcesPanel.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/scriptsPanel.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/splitView.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/tabbedPane.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/textPrompt.css
chrome/tools/test/reference_build/chrome_linux/resources/inspector/timelinePanel.css
chrome/tools/test/reference_build/chrome_linux/xdg-mime
chrome/tools/test/reference_build/chrome_linux/xdg-settings
seccompsandbox/LICENSE
seccompsandbox/linux_syscall_support.h

http://codereview.chromium.org/10832364/diff/1/build/android/buildbot_functio...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10832364/diff/1/build/android/buildbot_functio...
build/android/buildbot_functions.sh:318: echo "@@@STEP_FAILURE@@@"
To confirm: this means that the builder turns red when the license check fails.

http://codereview.chromium.org/10832364/diff/1/build/android/buildbot_functio...
build/android/buildbot_functions.sh:320: return $license_exit_code
nit: The return doesn't seem necessary, as it isn't used anywhere. We're rather
inconsistent here, though, so I guess it's fine to leave it as it is.

[Steve Block, 2012-08-17 11:54:44]

> Since the return code is 1, I guess this will make the
> builder turn red once this lands?
I won't land this until it's green, but wanted to upload the patch now so
somebody else can take over if we don't get there today.

> Got LicenseError "missing README.chromium or licenses.py SPECIAL_CASES entry"
> while scanning third_party/android
Where does this directory come from? I don't have it in my client and I don't
see it in DEPS.

> Got LicenseError "missing README.chromium or licenses.py SPECIAL_CASES entry"
> while scanning third_party/pylib
Is your client stale? - I think this was removed recently.

> chrome/tools/test/reference_build/chrome_linux/...
I don't have these file in my client: are they build output files? If so, I can
modify the tool to ignore them.

> seccompsandbox/LICENSE
> seccompsandbox/linux_syscall_support.h
Again, I don't have these files in my client?

[Peter Beverloo, 2012-08-17 13:48:27]

I have quite an old check-out, so it may be my client indeed. Furthermore, if
the FYI builder is red it's not the worst thing in the world.

LGTM, but please be sure to get Mikhail's/any full committer's LGTM too.

[Steve Block, 2012-08-17 14:32:46]

Thanks Peter. Mikhail is going to test locally on his checkout, then land this
once we're green.

[mnaganov (inactive), 2012-08-17 14:49:56]

On 2012/08/17 14:32:46, Steve Block wrote:
> Thanks Peter. Mikhail is going to test locally on his checkout, then land this
> once we're green.

I cleaned up offending paths from my linux checkout, did an android checkout,
and re-run the tool. I've got only one message -- about
third_party/android_tools which is being addressed by Armand.