Run the WebView license checker on the android FYI builder

build/android/buildbot_functions.sh

 #!/bin/bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Bash functions used by buildbot annotator scripts for the android
 # build of chromium.  Executing this script should not perform actions
 # other than setting variables and defining of functions.
 
 # Number of jobs on the compile line; e.g.  make -j"${JOBS}"
@@ skipping 165 matching lines @@
     TARGET_CC="$TARGET_CC" \
     TARGET_CXX="$TARGET_CXX" \
     CC.host="$HOST_CC" \
     CXX.host="$HOST_CXX" \
     CC.target="$TARGET_CC" \
     CXX.target="$TARGET_CXX" \
     LINK.target="$TARGET_CXX" \
     COMMON_JAVAC="$COMMON_JAVAC" \
     "$@"
 
-  local make_exit_status=$?
+  local make_exit_code=$?
   bb_stop_goma_internal
-  return $make_exit_status
+  return $make_exit_code
 }
 
 # Compile step
 function bb_compile {
   # This must be named 'compile', not 'Compile', for CQ interaction.
   # Talk to maruel for details.
   echo "@@@BUILD_STEP compile@@@"
   bb_goma_make
 }
 
@@ skipping 76 matching lines @@
   # code 1.  We disable halt on error mode and return normally
   # unless the python tool returns 1.
   (
   set +e
   python ../../../../scripts/slave/extract_build.py \
     --build-dir "$SRC_ROOT" \
     --build-output-dir "out" \
     --target Release \
     --factory-properties "$FACTORY_PROPERTIES" \
     --build-properties "$BUILD_PROPERTIES"
-  extract_exitcode=$?
-  if (( $extract_exitcode > 1 )); then
+  local extract_exit_code=$?
+  if (( $extract_exit_code > 1 )); then
     echo "@@@STEP_WARNINGS@@@"
     return
   fi
-  return $extract_exitcode
+  return $extract_exit_code
   )
 }
 
 # Reboot all phones and wait for them to start back up
 # Does not break build if a phone fails to restart
 function bb_reboot_phones {
   echo "@@@BUILD_STEP Rebooting phones@@@"
   (
   set +e
   cd $CHROME_SRC/build/android/pylib;
   for DEVICE in $(adb_get_devices); do
     python -c "import android_commands;\
         android_commands.AndroidCommands(device='$DEVICE').Reboot(True)" &
   done
   wait
   )
 }
+
+# Runs the license checker for the WebView build.
+function bb_check_webview_licenses {
+  echo "@@@BUILD_STEP Check licenses for WebView@@@"
+  (
+  set +e
+  cd "${SRC_ROOT}"
+  python android_webview/tools/webview_licenses.py scan
+  local license_exit_code = $?
+  if [[ license_exit_code -ne 0 ]]; then
+    echo "@@@STEP_FAILURE@@@"

[Peter Beverloo, 2012/08/17 11:40:45]

To confirm: this means that the builder turns red when the license check fails.

+  fi
+  return $license_exit_code

[Peter Beverloo, 2012/08/17 11:40:45]

nit: The return doesn't seem necessary, as it isn't used anywhere. We're rather
inconsistent here, though, so I guess it's fine to leave it as it is.

+  )
+}