Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 10832180: Eliminate phis that do not reach any non-environment uses. (Closed)

Created:
8 years, 4 months ago by Vyacheslav Egorov (Google)
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate phis that do not reach any non-environment uses. This takes care of phis for temporary variables like :expr_temp, lia, lix, igr, casc, alloc, sca that currently create unnecessary pressure on the back-edge of loops. R=srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10377

Patch Set 1 #

Total comments: 1

Patch Set 2 : address Kevin's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -23 lines) Patch
M runtime/vm/flow_graph_allocator.cc View 1 2 chunks +24 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 8 chunks +48 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 4 chunks +12 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vyacheslav Egorov (Google)
8 years, 4 months ago (2012-08-07 16:06:48 UTC) #1
Vyacheslav Egorov (Google)
routing to Kevin for review.
8 years, 4 months ago (2012-08-08 10:21:56 UTC) #2
Kevin Millikin (Google)
Hacky. We should try to get rid of these local variables. LGTM. http://codereview.chromium.org/10832180/diff/1/runtime/vm/flow_graph_allocator.cc File runtime/vm/flow_graph_allocator.cc ...
8 years, 4 months ago (2012-08-08 11:07:43 UTC) #3
Vyacheslav Egorov (Google)
PTAL
8 years, 4 months ago (2012-08-08 11:49:35 UTC) #4
Kevin Millikin (Google)
8 years, 4 months ago (2012-08-08 12:09:59 UTC) #5
Changes LGTM.

Powered by Google App Engine
This is Rietveld 408576698