Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 10832153: libwebp: update snapshot to v0.2.0-rc1 (Closed)

Created:
8 years, 4 months ago by jzern
Modified:
8 years, 4 months ago
CC:
chromium-reviews, skal, scherkus (not reviewing)
Visibility:
Public.

Description

libwebp: update snapshot to v0.2.0-rc1 adds lossless encoder/decoder with alpha support. the same is to used to add alpha+VP8 support. BUG=139925 BUG=133161 TEST=webkit layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150264

Patch Set 1 #

Patch Set 2 : add android specific include paths #

Patch Set 3 : gyp changes for dsp/{cpu,dec_neon}.c #

Patch Set 4 : encoder reversions #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12529 lines, -2485 lines) Patch
M third_party/libwebp/README.chromium View 1 2 3 4 5 1 chunk +18 lines, -17 lines 0 comments Download
M third_party/libwebp/dec/alpha.c View 2 chunks +110 lines, -39 lines 0 comments Download
M third_party/libwebp/dec/buffer.c View 10 chunks +48 lines, -31 lines 0 comments Download
A + third_party/libwebp/dec/decode_vp8.h View 4 chunks +43 lines, -18 lines 0 comments Download
M third_party/libwebp/dec/frame.c View 13 chunks +194 lines, -179 lines 0 comments Download
M third_party/libwebp/dec/idec.c View 22 chunks +262 lines, -165 lines 0 comments Download
M third_party/libwebp/dec/io.c View 14 chunks +201 lines, -258 lines 0 comments Download
M third_party/libwebp/dec/layer.c View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/libwebp/dec/quant.c View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/libwebp/dec/tree.c View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/libwebp/dec/vp8.c View 15 chunks +63 lines, -51 lines 0 comments Download
M third_party/libwebp/dec/vp8i.h View 8 chunks +9 lines, -19 lines 0 comments Download
A third_party/libwebp/dec/vp8l.c View 1 chunk +1215 lines, -0 lines 0 comments Download
A third_party/libwebp/dec/vp8li.h View 1 chunk +121 lines, -0 lines 0 comments Download
M third_party/libwebp/dec/webp.c View 15 chunks +414 lines, -240 lines 0 comments Download
M third_party/libwebp/dec/webpi.h View 6 chunks +32 lines, -81 lines 0 comments Download
M third_party/libwebp/dsp/cpu.c View 5 chunks +23 lines, -8 lines 0 comments Download
A third_party/libwebp/dsp/cpu-features.h View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp/cpu-features.c View 1 2 3 1 chunk +555 lines, -0 lines 0 comments Download
M third_party/libwebp/dsp/dec.c View 13 chunks +23 lines, -20 lines 0 comments Download
M third_party/libwebp/dsp/dec_neon.c View 4 chunks +165 lines, -4 lines 0 comments Download
M third_party/libwebp/dsp/dec_sse2.c View 10 chunks +23 lines, -18 lines 0 comments Download
M third_party/libwebp/dsp/dsp.h View 7 chunks +44 lines, -9 lines 0 comments Download
M third_party/libwebp/dsp/enc.c View 13 chunks +20 lines, -21 lines 0 comments Download
M third_party/libwebp/dsp/enc_sse2.c View 3 chunks +6 lines, -3 lines 0 comments Download
A third_party/libwebp/dsp/lossless.h View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp/lossless.c View 1 chunk +1124 lines, -0 lines 0 comments Download
M third_party/libwebp/dsp/upsampling.c View 8 chunks +149 lines, -20 lines 0 comments Download
M third_party/libwebp/dsp/upsampling_sse2.c View 4 chunks +11 lines, -17 lines 0 comments Download
M third_party/libwebp/dsp/yuv.h View 5 chunks +54 lines, -30 lines 0 comments Download
M third_party/libwebp/dsp/yuv.c View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/enc/alpha.c View 2 chunks +281 lines, -65 lines 0 comments Download
M third_party/libwebp/enc/analysis.c View 9 chunks +17 lines, -13 lines 0 comments Download
A third_party/libwebp/enc/backward_references.h View 1 chunk +212 lines, -0 lines 0 comments Download
A third_party/libwebp/enc/backward_references.c View 1 chunk +874 lines, -0 lines 0 comments Download
M third_party/libwebp/enc/config.c View 6 chunks +17 lines, -6 lines 0 comments Download
M third_party/libwebp/enc/cost.h View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/libwebp/enc/cost.c View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M third_party/libwebp/enc/filter.c View 9 chunks +56 lines, -25 lines 0 comments Download
M third_party/libwebp/enc/frame.c View 1 2 3 21 chunks +272 lines, -73 lines 0 comments Download
A third_party/libwebp/enc/histogram.h View 1 chunk +115 lines, -0 lines 0 comments Download
A third_party/libwebp/enc/histogram.c View 1 chunk +406 lines, -0 lines 0 comments Download
M third_party/libwebp/enc/iterator.c View 11 chunks +104 lines, -91 lines 0 comments Download
M third_party/libwebp/enc/layer.c View 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/libwebp/enc/picture.c View 12 chunks +732 lines, -355 lines 0 comments Download
M third_party/libwebp/enc/quant.c View 9 chunks +17 lines, -17 lines 0 comments Download
M third_party/libwebp/enc/syntax.c View 8 chunks +201 lines, -68 lines 0 comments Download
M third_party/libwebp/enc/tree.c View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/enc/vp8enci.h View 1 2 3 14 chunks +81 lines, -18 lines 0 comments Download
A third_party/libwebp/enc/vp8l.c View 1 chunk +1137 lines, -0 lines 0 comments Download
A third_party/libwebp/enc/vp8li.h View 1 chunk +68 lines, -0 lines 0 comments Download
M third_party/libwebp/enc/webpenc.c View 11 chunks +75 lines, -37 lines 0 comments Download
M third_party/libwebp/libwebp.gyp View 1 2 3 4 chunks +62 lines, -22 lines 1 comment Download
M third_party/libwebp/utils/bit_reader.h View 5 chunks +125 lines, -37 lines 0 comments Download
M third_party/libwebp/utils/bit_reader.c View 4 chunks +166 lines, -16 lines 0 comments Download
M third_party/libwebp/utils/bit_writer.h View 2 chunks +65 lines, -5 lines 0 comments Download
M third_party/libwebp/utils/bit_writer.c View 5 chunks +107 lines, -9 lines 0 comments Download
A third_party/libwebp/utils/color_cache.h View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/color_cache.c View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/filters.h View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/filters.c View 1 chunk +229 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/huffman.h View 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/huffman.c View 1 chunk +238 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/huffman_encode.h View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/huffman_encode.c View 1 chunk +439 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/quant_levels.h View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/quant_levels.c View 1 chunk +154 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/rescaler.h View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/rescaler.c View 1 chunk +152 lines, -0 lines 0 comments Download
M third_party/libwebp/utils/thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libwebp/utils/thread.c View 2 chunks +6 lines, -2 lines 0 comments Download
A third_party/libwebp/utils/utils.h View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/libwebp/utils/utils.c View 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/libwebp/webp/decode.h View 14 chunks +163 lines, -105 lines 0 comments Download
D third_party/libwebp/webp/decode_vp8.h View 1 chunk +0 lines, -157 lines 0 comments Download
M third_party/libwebp/webp/encode.h View 11 chunks +253 lines, -76 lines 0 comments Download
A third_party/libwebp/webp/format_constants.h View 1 chunk +90 lines, -0 lines 0 comments Download
M third_party/libwebp/webp/types.h View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
jzern
Sorry for the review abuse Andrew! A couple of things that need to get worked ...
8 years, 4 months ago (2012-08-04 22:53:00 UTC) #1
jzern
On 2012/08/04 22:53:00, jzern wrote: > Sorry for the review abuse Andrew! > > A ...
8 years, 4 months ago (2012-08-04 22:55:48 UTC) #2
jzern
On 2012/08/04 22:55:48, jzern wrote: > On 2012/08/04 22:53:00, jzern wrote: > > Sorry for ...
8 years, 4 months ago (2012-08-05 20:28:47 UTC) #3
jzern
Take a look, I made some modifications for the encode layout tests and android builds ...
8 years, 4 months ago (2012-08-06 18:59:08 UTC) #4
Ami GONE FROM CHROMIUM
LGTM http://codereview.chromium.org/10832153/diff/15001/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): http://codereview.chromium.org/10832153/diff/15001/third_party/libwebp/README.chromium#newcode24 third_party/libwebp/README.chromium:24: * Revert VP8 encoder changes to avoid WebKit ...
8 years, 4 months ago (2012-08-06 21:01:05 UTC) #5
Ami GONE FROM CHROMIUM
On 2012/08/04 22:53:00, jzern wrote: > 2) webkit layout tests: */fast/canvas/canvas-toDataURL-webp.html > The output from ...
8 years, 4 months ago (2012-08-06 21:04:57 UTC) #6
Ami GONE FROM CHROMIUM
On 2012/08/04 22:53:00, jzern wrote: > I imagine the test will need to be made ...
8 years, 4 months ago (2012-08-06 21:05:35 UTC) #7
jzern
On 2012/08/06 21:01:05, Ami Fischman wrote: > LGTM > > http://codereview.chromium.org/10832153/diff/15001/third_party/libwebp/README.chromium > File third_party/libwebp/README.chromium (right): ...
8 years, 4 months ago (2012-08-06 22:13:16 UTC) #8
Ami GONE FROM CHROMIUM
On 2012/08/06 22:13:16, jzern wrote: > On 2012/08/06 21:01:05, Ami Fischman wrote: > > LGTM ...
8 years, 4 months ago (2012-08-06 22:16:40 UTC) #9
jzern
On 2012/08/06 22:16:40, Ami Fischman wrote: > On 2012/08/06 22:13:16, jzern wrote: > > On ...
8 years, 4 months ago (2012-08-06 22:29:43 UTC) #10
jzern
On 2012/08/06 22:29:43, jzern wrote: > On 2012/08/06 22:16:40, Ami Fischman wrote: > > > ...
8 years, 4 months ago (2012-08-07 00:17:01 UTC) #11
Noel Gordon
On 2012/08/06 21:05:35, Ami Fischman wrote: > On 2012/08/04 22:53:00, jzern wrote: > > I ...
8 years, 4 months ago (2012-08-07 00:20:33 UTC) #12
jzern
http://codereview.chromium.org/10832153/diff/15001/third_party/libwebp/README.chromium File third_party/libwebp/README.chromium (right): http://codereview.chromium.org/10832153/diff/15001/third_party/libwebp/README.chromium#newcode24 third_party/libwebp/README.chromium:24: * Revert VP8 encoder changes to avoid WebKit layout ...
8 years, 4 months ago (2012-08-07 00:24:54 UTC) #13
jzern
On 2012/08/07 00:20:33, noel chromium wrote: > On 2012/08/06 21:05:35, Ami Fischman wrote: > > ...
8 years, 4 months ago (2012-08-07 00:26:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/10832153/16001
8 years, 4 months ago (2012-08-07 01:29:12 UTC) #15
commit-bot: I haz the power
Change committed as 150264
8 years, 4 months ago (2012-08-07 04:04:47 UTC) #16
Nico
https://chromiumcodereview.appspot.com/10832153/diff/16001/third_party/libwebp/libwebp.gyp File third_party/libwebp/libwebp.gyp (right): https://chromiumcodereview.appspot.com/10832153/diff/16001/third_party/libwebp/libwebp.gyp#newcode62 third_party/libwebp/libwebp.gyp:62: 'target_name': 'libwebp_dsp_neon', This causes the following build warning in ...
8 years, 4 months ago (2012-08-10 20:01:54 UTC) #17
jzern
8 years, 4 months ago (2012-08-10 21:02:25 UTC) #18
On 2012/08/10 20:01:54, Nico wrote:
> [...]
> 
> We try very hard to be warning-free, and this is now our only build warning.
Can
> you please take a look? One possible technique, used by a neon target in
webkit,
> is to make this target type 'none' on non-neon platforms. Here's how this is
> done in third_party/WebKit/Source/WebCore/WebCore.gyp:
> 
Thanks for the suggestion, I'll have a look. I opened the following bug to
track:

  https://code.google.com/p/chromium/issues/detail?id=141949

Powered by Google App Engine
This is Rietveld 408576698