Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/resources/options2/manage_profile_overlay.html

Issue 10832075: Create/Manage dialog UI changes for M22 (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/manage_profile_overlay.html
===================================================================
--- chrome/browser/resources/options2/manage_profile_overlay.html (revision 149057)
+++ chrome/browser/resources/options2/manage_profile_overlay.html (working copy)
@@ -8,14 +8,17 @@
i18n-content="manageProfilesIconLabel">
</div>
<grid id="manage-profile-icon-grid"></grid>
- <div id="manage-profile-name-div">
+ <div class="profile-name-area">
James Hawkins 2012/07/31 17:01:07 Optional nit: s/area/container/
Halli 2012/07/31 23:57:51 Done.
<span id="manage-profile-name-label"
i18n-content="manageProfilesNameLabel"></span>
+ </div>
+ <div class="profile-name-area">
<input id="manage-profile-name" type="text" required>
</div>
<div id="manage-profile-error-bubble" hidden>
</div>
</div>
+ <div id="manage-profile-separator"></div>
James Hawkins 2012/07/31 17:01:07 What is this div about?
Halli 2012/07/31 17:37:05 See comment on .css file. I added a separate div t
<div class="action-area">
<!-- TODO: (hallielaine) activate this checkbox, and add hooks for
shortcut creation in M23
@@ -56,14 +59,17 @@
<div id="create-profile-content" class="content-area">
<div id="create-profile-instructions"></div>
<grid id="create-profile-icon-grid"></grid>
- <div id="create-profile-name-div">
+ <div class="profile-name-area">
<span id="create-profile-name-label"
i18n-content="manageProfilesNameLabel">
</span>
+ </div>
+ <div class="profile-name-area">
<input id="create-profile-name" type="text" required>
</div>
<div id="create-profile-error-bubble" hidden></div>
</div>
+ <div id="create-profile-separator"></div>
<div class="action-area">
<!-- TODO: (hallielaine) activate this checkbox, and add hooks for
shortcut creation in M23

Powered by Google App Engine
This is Rietveld 408576698