Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <div id="manage-profile-overlay" class="page" hidden> | 1 <div id="manage-profile-overlay" class="page" hidden> |
| 2 <div class="close-button"></div> | 2 <div class="close-button"></div> |
| 3 <!-- Dialog for managing profiles. --> | 3 <!-- Dialog for managing profiles. --> |
| 4 <div id="manage-profile-overlay-manage" hidden> | 4 <div id="manage-profile-overlay-manage" hidden> |
| 5 <h1 i18n-content="manageProfile"></h1> | 5 <h1 i18n-content="manageProfile"></h1> |
| 6 <div id="manage-profile-content" class="content-area"> | 6 <div id="manage-profile-content" class="content-area"> |
| 7 <div id="manage-profile-icon-label" | 7 <div id="manage-profile-icon-label" |
| 8 i18n-content="manageProfilesIconLabel"> | 8 i18n-content="manageProfilesIconLabel"> |
| 9 </div> | 9 </div> |
| 10 <grid id="manage-profile-icon-grid"></grid> | 10 <grid id="manage-profile-icon-grid"></grid> |
| 11 <div id="manage-profile-name-div"> | 11 <div class="profile-name-area"> |
|
James Hawkins
2012/07/31 17:01:07
Optional nit: s/area/container/
Halli
2012/07/31 23:57:51
Done.
| |
| 12 <span id="manage-profile-name-label" | 12 <span id="manage-profile-name-label" |
| 13 i18n-content="manageProfilesNameLabel"></span> | 13 i18n-content="manageProfilesNameLabel"></span> |
| 14 </div> | |
| 15 <div class="profile-name-area"> | |
| 14 <input id="manage-profile-name" type="text" required> | 16 <input id="manage-profile-name" type="text" required> |
| 15 </div> | 17 </div> |
| 16 <div id="manage-profile-error-bubble" hidden> | 18 <div id="manage-profile-error-bubble" hidden> |
| 17 </div> | 19 </div> |
| 18 </div> | 20 </div> |
| 21 <div id="manage-profile-separator"></div> | |
|
James Hawkins
2012/07/31 17:01:07
What is this div about?
Halli
2012/07/31 17:37:05
See comment on .css file. I added a separate div t
| |
| 19 <div class="action-area"> | 22 <div class="action-area"> |
| 20 <!-- TODO: (hallielaine) activate this checkbox, and add hooks for | 23 <!-- TODO: (hallielaine) activate this checkbox, and add hooks for |
| 21 shortcut creation in M23 | 24 shortcut creation in M23 |
| 22 <div class="action-area-checkbox-container"> | 25 <div class="action-area-checkbox-container"> |
| 23 <div class="checkbox"> | 26 <div class="checkbox"> |
| 24 <label> | 27 <label> |
| 25 <input id="manage-shortcut" type="checkbox"> | 28 <input id="manage-shortcut" type="checkbox"> |
| 26 <span for="manage-shortcut" | 29 <span for="manage-shortcut" |
| 27 i18n-content="createProfileShortcut"> | 30 i18n-content="createProfileShortcut"> |
| 28 </span> | 31 </span> |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 49 i18n-content="deleteProfileOK"></button> | 52 i18n-content="deleteProfileOK"></button> |
| 50 </div> | 53 </div> |
| 51 </div> | 54 </div> |
| 52 </div> | 55 </div> |
| 53 <!-- Dialog for creating profiles. --> | 56 <!-- Dialog for creating profiles. --> |
| 54 <div id="manage-profile-overlay-create" hidden> | 57 <div id="manage-profile-overlay-create" hidden> |
| 55 <h1 i18n-content="createProfileTitle"></h1> | 58 <h1 i18n-content="createProfileTitle"></h1> |
| 56 <div id="create-profile-content" class="content-area"> | 59 <div id="create-profile-content" class="content-area"> |
| 57 <div id="create-profile-instructions"></div> | 60 <div id="create-profile-instructions"></div> |
| 58 <grid id="create-profile-icon-grid"></grid> | 61 <grid id="create-profile-icon-grid"></grid> |
| 59 <div id="create-profile-name-div"> | 62 <div class="profile-name-area"> |
| 60 <span id="create-profile-name-label" | 63 <span id="create-profile-name-label" |
| 61 i18n-content="manageProfilesNameLabel"> | 64 i18n-content="manageProfilesNameLabel"> |
| 62 </span> | 65 </span> |
| 66 </div> | |
| 67 <div class="profile-name-area"> | |
| 63 <input id="create-profile-name" type="text" required> | 68 <input id="create-profile-name" type="text" required> |
| 64 </div> | 69 </div> |
| 65 <div id="create-profile-error-bubble" hidden></div> | 70 <div id="create-profile-error-bubble" hidden></div> |
| 66 </div> | 71 </div> |
| 72 <div id="create-profile-separator"></div> | |
| 67 <div class="action-area"> | 73 <div class="action-area"> |
| 68 <!-- TODO: (hallielaine) activate this checkbox, and add hooks for | 74 <!-- TODO: (hallielaine) activate this checkbox, and add hooks for |
| 69 shortcut creation in M23 | 75 shortcut creation in M23 |
| 70 <div class="action-area-checkbox-container"> | 76 <div class="action-area-checkbox-container"> |
| 71 <div class="checkbox"> | 77 <div class="checkbox"> |
| 72 <label> | 78 <label> |
| 73 <input id="create-shortcut" type="checkbox"> | 79 <input id="create-shortcut" type="checkbox"> |
| 74 <span for="create-shortcut" | 80 <span for="create-shortcut" |
| 75 i18n-content="createProfileShortcut"> | 81 i18n-content="createProfileShortcut"> |
| 76 </span> | 82 </span> |
| 77 </label> | 83 </label> |
| 78 </div> | 84 </div> |
| 79 </div> | 85 </div> |
| 80 --> | 86 --> |
| 81 <div class="button-strip"> | 87 <div class="button-strip"> |
| 82 <button id="create-profile-cancel" i18n-content="cancel"></button> | 88 <button id="create-profile-cancel" i18n-content="cancel"></button> |
| 83 <button id="create-profile-ok" i18n-content="createProfileConfirm"> | 89 <button id="create-profile-ok" i18n-content="createProfileConfirm"> |
| 84 </button> | 90 </button> |
| 85 </div> | 91 </div> |
| 86 </div> | 92 </div> |
| 87 </div> | 93 </div> |
| 88 </div> | 94 </div> |
| OLD | NEW |