Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: chrome/browser/chromeos/cros_settings.h

Issue 10832035: Switch from SignedSettings to DeviceSettingsService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More test fixing... Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros_settings.h
diff --git a/chrome/browser/chromeos/cros_settings.h b/chrome/browser/chromeos/cros_settings.h
index 4ff048ff0c5d0a937e666e95b666d0af48fc544b..6d77b701a5e6072352810bac99c6eecfc30e164e 100644
--- a/chrome/browser/chromeos/cros_settings.h
+++ b/chrome/browser/chromeos/cros_settings.h
@@ -27,6 +27,10 @@ namespace chromeos {
// This class manages per-device/global settings.
class CrosSettings : public base::NonThreadSafe {
public:
+ // Public for testing.
pastarmovj 2012/07/30 13:55:02 This looks dangerous to me. It gets too easy to in
Mattias Nissler (ping if slow) 2012/08/02 12:01:52 Done.
+ CrosSettings();
+ ~CrosSettings();
+
// Class factory.
static CrosSettings* Get();
@@ -91,13 +95,7 @@ class CrosSettings : public base::NonThreadSafe {
// Returns the provider that handles settings with the |path| or prefix.
CrosSettingsProvider* GetProvider(const std::string& path) const;
- // Forces all providers to reload their caches from the respective backing
- // stores if they have any.
- void ReloadProviders();
-
private:
- friend struct base::DefaultLazyInstanceTraits<CrosSettings>;
-
// List of ChromeOS system settings providers.
std::vector<CrosSettingsProvider*> providers_;
@@ -109,9 +107,6 @@ class CrosSettings : public base::NonThreadSafe {
SettingsObserverMap;
SettingsObserverMap settings_observers_;
- CrosSettings();
- ~CrosSettings();
-
// Fires system setting change notification.
void FireObservers(const std::string& path);

Powered by Google App Engine
This is Rietveld 408576698