Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: chrome/browser/chromeos/cros_settings.cc

Issue 10832035: Switch from SignedSettings to DeviceSettingsService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More test fixing... Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros_settings.cc
diff --git a/chrome/browser/chromeos/cros_settings.cc b/chrome/browser/chromeos/cros_settings.cc
index 98402dcca950395c63bdb8f48ef56ecc2fa3d5d2..f0f2cb4aaf408741a25b283d15e9e594334301ff 100644
--- a/chrome/browser/chromeos/cros_settings.cc
+++ b/chrome/browser/chromeos/cros_settings.cc
@@ -11,7 +11,7 @@
#include "base/string_util.h"
#include "base/values.h"
#include "chrome/browser/chromeos/device_settings_provider.h"
-#include "chrome/browser/chromeos/login/signed_settings_helper.h"
+#include "chrome/browser/chromeos/login/device_settings_service.h"
#include "chrome/browser/chromeos/stub_cros_settings_provider.h"
#include "chrome/browser/chromeos/system_settings_provider.h"
#include "chrome/common/chrome_notification_types.h"
@@ -26,6 +26,27 @@ namespace chromeos {
static base::LazyInstance<CrosSettings> g_cros_settings =
LAZY_INSTANCE_INITIALIZER;
+CrosSettings::CrosSettings() {
+ CrosSettingsProvider::NotifyObserversCallback notify_cb(
+ base::Bind(&CrosSettings::FireObservers,
+ // This is safe since |this| is never deleted.
+ base::Unretained(this)));
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kStubCrosSettings)) {
+ AddSettingsProvider(new StubCrosSettingsProvider(notify_cb));
+ } else {
+ AddSettingsProvider(
+ new DeviceSettingsProvider(notify_cb, DeviceSettingsService::Get()));
+ }
+ // System settings are not mocked currently.
+ AddSettingsProvider(new SystemSettingsProvider(notify_cb));
+}
+
+CrosSettings::~CrosSettings() {
+ STLDeleteElements(&providers_);
+ STLDeleteValues(&settings_observers_);
+}
+
CrosSettings* CrosSettings::Get() {
// TODO(xiyaun): Use real stuff when underlying libcros is ready.
return g_cros_settings.Pointer();
@@ -220,11 +241,6 @@ CrosSettingsProvider* CrosSettings::GetProvider(
return NULL;
}
-void CrosSettings::ReloadProviders() {
- for (size_t i = 0; i < providers_.size(); ++i)
- providers_[i]->Reload();
-}
-
const base::Value* CrosSettings::GetPref(const std::string& path) const {
DCHECK(CalledOnValidThread());
CrosSettingsProvider* provider = GetProvider(path);
@@ -291,25 +307,4 @@ bool CrosSettings::GetList(const std::string& path,
return false;
}
-CrosSettings::CrosSettings() {
- CrosSettingsProvider::NotifyObserversCallback notify_cb(
- base::Bind(&CrosSettings::FireObservers,
- // This is safe since |this| is never deleted.
- base::Unretained(this)));
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kStubCrosSettings)) {
- AddSettingsProvider(new StubCrosSettingsProvider(notify_cb));
- } else {
- AddSettingsProvider(
- new DeviceSettingsProvider(notify_cb, SignedSettingsHelper::Get()));
- }
- // System settings are not mocked currently.
- AddSettingsProvider(new SystemSettingsProvider(notify_cb));
-}
-
-CrosSettings::~CrosSettings() {
- STLDeleteElements(&providers_);
- STLDeleteValues(&settings_observers_);
-}
-
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698