Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4303)

Unified Diff: chrome/service/net/service_url_request_context.cc

Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add ChromeBrowserFieldTrials::AsyncDnsFieldTrial Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/net/service_url_request_context.cc
diff --git a/chrome/service/net/service_url_request_context.cc b/chrome/service/net/service_url_request_context.cc
index 1050e29d6fdc572975645593b2fee310c7178f16..7238d7f2155af21550d336451dd5e577ab047d4c 100644
--- a/chrome/service/net/service_url_request_context.cc
+++ b/chrome/service/net/service_url_request_context.cc
@@ -110,9 +110,7 @@ ServiceURLRequestContext::ServiceURLRequestContext(
: user_agent_(user_agent),
ALLOW_THIS_IN_INITIALIZER_LIST(storage_(this)) {
storage_.set_host_resolver(
cbentzel 2012/08/16 20:09:21 Could |set_host_resolver| change to take a scoped_
szym 2012/08/16 20:38:55 Ultimately, I'd strongly prefer that. If you can t
cbentzel 2012/08/16 21:20:26 I can. May want to get mmenke or willchan to chime
- net::CreateSystemHostResolver(net::HostResolver::kDefaultParallelism,
- net::HostResolver::kDefaultRetryAttempts,
- NULL));
+ net::HostResolver::CreateDefaultResolver(NULL).release());
storage_.set_proxy_service(net::ProxyService::CreateUsingSystemProxyResolver(
net_proxy_config_service, 0u, NULL));
storage_.set_cert_verifier(net::CertVerifier::CreateDefault());

Powered by Google App Engine
This is Rietveld 408576698