[net] Change factory methods for HostResolver and HostCache to return a scoped_ptr

chrome/service/net/service_url_request_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/net/service_url_request_context.h"
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 #include <sys/utsname.h>
 #endif
 
@@ skipping 91 matching lines @@
   return user_agent;
 }
 
 }  // namespace
 
 ServiceURLRequestContext::ServiceURLRequestContext(
     const std::string& user_agent,
     net::ProxyConfigService* net_proxy_config_service)
     : user_agent_(user_agent),
       ALLOW_THIS_IN_INITIALIZER_LIST(storage_(this)) {
   storage_.set_host_resolver(

[cbentzel, 2012/08/16 20:09:21]

Could |set_host_resolver| change to take a scoped_ptr argument?

[szym, 2012/08/16 20:38:55]

Ultimately, I'd strongly prefer that. If you can tolerate a small (and hopefully
temporary) inconsistency between set_host_resolver and all the other setters in
URLRequestContextStorage then I'd definitely do that.

[cbentzel, 2012/08/16 21:20:26]

I can. May want to get mmenke or willchan to chime in.

-      net::CreateSystemHostResolver(net::HostResolver::kDefaultParallelism,
-                                    net::HostResolver::kDefaultRetryAttempts,
-                                    NULL));
+      net::HostResolver::CreateDefaultResolver(NULL).release());
   storage_.set_proxy_service(net::ProxyService::CreateUsingSystemProxyResolver(
       net_proxy_config_service, 0u, NULL));
   storage_.set_cert_verifier(net::CertVerifier::CreateDefault());
   storage_.set_ftp_transaction_factory(
       new net::FtpNetworkLayer(host_resolver()));
   storage_.set_ssl_config_service(new net::SSLConfigServiceDefaults);
   storage_.set_http_auth_handler_factory(
       net::HttpAuthHandlerFactory::CreateDefault(host_resolver()));
   storage_.set_http_server_properties(new net::HttpServerPropertiesImpl);
   storage_.set_transport_security_state(new net::TransportSecurityState);
@@ skipping 51 matching lines @@
                                      proxy_config_service_.release()));
   return url_request_context_.get();
 }
 
 scoped_refptr<base::SingleThreadTaskRunner>
 ServiceURLRequestContextGetter::GetNetworkTaskRunner() const {
   return network_task_runner_;
 }
 
 ServiceURLRequestContextGetter::~ServiceURLRequestContextGetter() {}