Refactor and fix declarative webRequest API permissions

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index ba17841c743a37b9bcc5953b625b3b2402eb2918..765064feab08d5be028871c551e5b901b2653286 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1047,6 +1047,12 @@ void ExtensionService::NotifyExtensionUnloaded(
       chrome::NOTIFICATION_EXTENSION_UNLOADED,
       content::Source<Profile>(profile_),
       content::Details<UnloadedExtensionInfo>(&details));
+  if (profile_->HasOffTheRecordProfile()) {
+    content::NotificationService::current()->Notify(
+          chrome::NOTIFICATION_EXTENSION_UNLOADED,
+          content::Source<Profile>(profile_->GetOffTheRecordProfile()),
+          content::Details<UnloadedExtensionInfo>(&details));

[battre, 2012/07/25 18:12:04]

I wonder whether this change may have any negative consequences.

[Matt Perry, 2012/07/25 21:27:56]

It's unconventional. Most of our notifications for extensions are sent only from
the main profile, because the incognito profile shares the extensions. I think
you should remove this and look for another way (I don't actually see where this
notification is observed in this CL).

[Yoyo Zhou, 2012/07/25 21:44:45]

I don't think this is a good idea. It's better to set up the observer to observe
the source profile->GetOriginalProfile().

[battre, 2012/07/26 16:38:43]

Done.

+  }
 
   for (content::RenderProcessHost::iterator i(
           content::RenderProcessHost::AllHostsIterator());