Refactor and fix declarative webRequest API permissions

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 1029 matching lines @@
 }
 
 void ExtensionService::NotifyExtensionUnloaded(
     const Extension* extension,
     extension_misc::UnloadedExtensionReason reason) {
   UnloadedExtensionInfo details(extension, reason);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_UNLOADED,
       content::Source<Profile>(profile_),
       content::Details<UnloadedExtensionInfo>(&details));
+  if (profile_->HasOffTheRecordProfile()) {
+    content::NotificationService::current()->Notify(
+          chrome::NOTIFICATION_EXTENSION_UNLOADED,
+          content::Source<Profile>(profile_->GetOffTheRecordProfile()),
+          content::Details<UnloadedExtensionInfo>(&details));

[battre, 2012/07/25 18:12:04]

I wonder whether this change may have any negative consequences.

[Matt Perry, 2012/07/25 21:27:56]

It's unconventional. Most of our notifications for extensions are sent only from
the main profile, because the incognito profile shares the extensions. I think
you should remove this and look for another way (I don't actually see where this
notification is observed in this CL).

[Yoyo Zhou, 2012/07/25 21:44:45]

I don't think this is a good idea. It's better to set up the observer to observe
the source profile->GetOriginalProfile().

[battre, 2012/07/26 16:38:43]

Done.

+  }
 
   for (content::RenderProcessHost::iterator i(
           content::RenderProcessHost::AllHostsIterator());
        !i.IsAtEnd(); i.Advance()) {
     content::RenderProcessHost* host = i.GetCurrentValue();
     Profile* host_profile =
         Profile::FromBrowserContext(host->GetBrowserContext());
     if (host_profile->GetOriginalProfile() == profile_->GetOriginalProfile())
       host->Send(new ExtensionMsg_Unloaded(extension->id()));
   }
@@ skipping 1479 matching lines @@
 
 ExtensionService::NaClModuleInfoList::iterator
     ExtensionService::FindNaClModule(const GURL& url) {
   for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
        iter != nacl_module_list_.end(); ++iter) {
     if (iter->url == url)
       return iter;
   }
   return nacl_module_list_.end();
 }