Extensions Docs Server: Uniform handling of file not found errors

chrome/common/extensions/docs/server2/api_list_data_source.py

Index: chrome/common/extensions/docs/server2/api_list_data_source.py
diff --git a/chrome/common/extensions/docs/server2/api_list_data_source.py b/chrome/common/extensions/docs/server2/api_list_data_source.py
index 5fd607ecaed02b6bc746e9a4b1c30f802f30cf94..e65cdadcfa34f142399b1e4babfbfd6dcd004926 100644
--- a/chrome/common/extensions/docs/server2/api_list_data_source.py
+++ b/chrome/common/extensions/docs/server2/api_list_data_source.py
@@ -4,6 +4,7 @@
 
 import os
 
+from file_system import FileNotFoundError
 import third_party.json_schema_compiler.model as model
 from docs_server_utils import SanitizeAPIName
 
@@ -52,5 +53,5 @@ class APIListDataSource(object):
   def get(self, key):
     try:
       return self._cache.GetFromFileListing(self._api_path)[key]
-    except Exception as e:
+    except FileNotFoundError:

[not at google - send to devlin, 2012/08/10 06:12:16]

log error?

[cduvall, 2012/08/10 17:25:16]

Done.

[not at google - send to devlin, 2012/08/12 22:22:58]

By the same logic as ApiDataSource we shouldn't catch this error here. Let it be
an error so that the integration tests can catch it.

Though in this case I'm not sure FileNotFoundError is the correct error to
raise. The apps/extensions directory not being present would imply a programming
error (since we're controlling the data that calls this). So perhaps turn this
error into a ValueError (with an appropriate message, and constructed with the
old error of course... presuming that's possible).

[cduvall, 2012/08/13 18:44:05]

Used the error as a string plus a more specific message, I think that's the best
way to do it in python.

       return None