Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: chrome/common/extensions/docs/server2/api_data_source_test.py

Issue 10830252: Extensions Docs Server: Uniform handling of file not found errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/api_data_source_test.py
diff --git a/chrome/common/extensions/docs/server2/api_data_source_test.py b/chrome/common/extensions/docs/server2/api_data_source_test.py
index 253b084df3239bd025af0faef6fa424cc7336f0f..160a42e03caae13ea94253e30df05451b3d3408c 100755
--- a/chrome/common/extensions/docs/server2/api_data_source_test.py
+++ b/chrome/common/extensions/docs/server2/api_data_source_test.py
@@ -7,6 +7,7 @@ import json
import os
import unittest
+from file_system import FileNotFoundError
from file_system_cache import FileSystemCache
from local_file_system import LocalFileSystem
from api_data_source import APIDataSource
@@ -26,7 +27,7 @@ class APIDataSourceTest(unittest.TestCase):
def testSimple(self):
cache_builder = FileSystemCache.Builder(LocalFileSystem(self._base_path))
data_source_factory = APIDataSource.Factory(cache_builder,
- './',
+ '.',
FakeSamplesDataSource())
data_source = data_source_factory.Create({})
@@ -36,7 +37,7 @@ class APIDataSourceTest(unittest.TestCase):
self.assertEqual(expected, data_source['test_file'])
self.assertEqual(expected, data_source['testFile'])
self.assertEqual(expected, data_source['testFile.html'])
- self.assertRaises(OSError, data_source.get, 'junk')
+ self.assertRaises(FileNotFoundError, data_source.get, 'junk')
if __name__ == '__main__':
unittest.main()

Powered by Google App Engine
This is Rietveld 408576698