chrome/browser/value_store/testing_value_store.cc - Issue 10830022: Fixed check return warnings from Coverity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/value_store/testing_value_store.cc

Issue 10830022: Fixed check return warnings from Coverity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated per review comments. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/value_store/testing_value_store.cc

diff --git a/chrome/browser/value_store/testing_value_store.cc b/chrome/browser/value_store/testing_value_store.cc

index f5dbcb116ce9e40d3b593106b59cc313e8dd5da7..c079df5e5facc275aec6181c48fed0ee301f726e 100644

--- a/chrome/browser/value_store/testing_value_store.cc

+++ b/chrome/browser/value_store/testing_value_store.cc

@@ -98,8 +98,8 @@ ValueStore::WriteResult TestingValueStore::Set(

scoped_ptr<ValueStoreChangeList> changes(new ValueStoreChangeList());

for (DictionaryValue::Iterator it(settings); it.HasNext(); it.Advance()) {

Value* old_value = NULL;

- storage_.GetWithoutPathExpansion(it.key(), &old_value);

- if (!old_value || !old_value->Equals(&it.value())) {

+ if (!storage_.GetWithoutPathExpansion(it.key(), &old_value) ||

+ !old_value->Equals(&it.value())) {

changes->push_back(

ValueStoreChange(

it.key(),